Bug 952456 add a new feature to support non-text/rich text for B2G clipboard, but some apps (ex. SMS app) only handle plain-text. According to Bug 952456 Comment 79, we could put the functionality behind a pref for 2.5 to make sure it wouldn't break those apps on 2.5.

Add a new preference, clibboard.plainTextOnly. 1. On: we only support kUnicodeMIME in SetData/GetData. 2. Off: we can support different MIME types in SetData/GetData BTW, "copy image" is dependent on non-text/rich text support, so this menu item is also disabled after we turn it off.

Comment on attachment 8668325 [details] [diff] [review] Add pref toggle for copying/pasting only plain text on B2G (v4) Review of attachment 8668325 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comments addressed. ::: b2g/app/b2g.js @@ +1150,5 @@ > pref("b2g.multiscreen.chrome_remote_url", "chrome://b2g/content/shell_remote.html"); > pref("b2g.multiscreen.system_remote_url", "index_remote.html"); > > +// Clipboard only supports text/plain > +pref("clipboard.plainTextOnly", true); We can keep that to false on m-c. We'll switch to true once we branch if needed. ::: widget/gonk/nsClipboard.cpp @@ +51,5 @@ > > // Clear out the clipboard in order to set the new data > EmptyClipboard(aWhichClipboard); > > + // Bug 1210265: Use a pref to toggle rich text/non-text support Nit: no need to put the bug number in the comment, but add a full stop at the end. @@ +181,5 @@ > nsRefPtr<nsClipboardProxy> clipboardProxy = new nsClipboardProxy(); > return clipboardProxy->GetData(aTransferable, aWhichClipboard); > } > > + // Bug 1210265: Use a pref to toggle rich text/non-text support nit: same as the other comment.

Comment on attachment 8668325 [details] [diff] [review] Add pref toggle for copying/pasting only plain text on B2G (v4) Review of attachment 8668325 [details] [diff] [review]: ----------------------------------------------------------------- ::: b2g/app/b2g.js @@ +1150,5 @@ > pref("b2g.multiscreen.chrome_remote_url", "chrome://b2g/content/shell_remote.html"); > pref("b2g.multiscreen.system_remote_url", "index_remote.html"); > > +// Clipboard only supports text/plain > +pref("clipboard.plainTextOnly", true); OK.

Add a new preference, clibboard.plainTextOnly. 1. On: we only support kUnicodeMIME in SetData/GetData. 2. Off: we can support different MIME types in SetData/GetData BTW, "copy image" is dependent on non-text/rich text support, so this menu item is also disabled after we turn the pref off. Fix some mochitest errors.

Hi Sheriff, Could you please check in gaia and gecko parts together? Thanks.

https://github.com/mozilla-b2g/gaia/commit/e217e18b96aff349332373a3e6eedb6b8067a19a also gecko part landed :)