Closed
Bug 1210824
Opened 9 years ago
Closed 9 years ago
ADB pull from B2G Installer broken
Categories
(DevTools Graveyard :: WebIDE, defect)
DevTools Graveyard
WebIDE
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: gerard-majax, Assigned: jryans)
References
Details
Attachments
(3 files, 1 obsolete file)
After updating ADB Helper and Gecko to latest nightly of today, B2G Installer addon is unable to pull anything from device:
> Devices._devices["0d38fb1e0c599f53"].pull("/fstab.hammerhead", "/tmp/b2g-installer/hammerhead/blobs/fstab.hammerhead").then(v => { console.debug(v); }, e => { console.debug(e); });
> Object { , 1 de plus… }
> BAD_RESPONSE
> Devices._devices["0d38fb1e0c599f53"].pull("/system/bin/bridgemgrd", "/tmp/b2g-installer/hammerhead/blobs/system/bin/bridgemgrd").then(v => { console.debug(v); }, e => { console.debug(e); });
> Object { , 1 de plus… }
> BAD_RESPONSE
Both can be pulled by hand from CLI.
|
Reporter | |
Comment 1•9 years ago
|
||
|
|
Reporter | |
Comment 3•9 years ago
|
||
https://github.com/mozilla/adbhelper/commit/95cf54f3ca8ef5667655bcb9fcc0451431bfa063#diff-369a5f292b913be569e8eafd45b090baL279
https://github.com/mozilla/adbhelper/commit/95cf54f3ca8ef5667655bcb9fcc0451431bfa063#diff-369a5f292b913be569e8eafd45b090baL279
> _checkResponse: function adb_checkResponse(aPacket, expected) {
...
> return view[0] == expected;
This was called by: (!client.checkResponse(aData, STAT))
Now we have from adb-client.js:
> function checkResponse(aPacket) {
...
> return view[0] == OKAY;
So the second parameter is not even used.
|
|
Reporter | |
Comment 4•9 years ago
|
||
That fixes the improper response checking.
Attachment #8668993 -
Flags: review?(jryans)
|
|
Reporter | |
Comment 5•9 years ago
|
||
|
|
Reporter | |
Comment 6•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #5)
> Created attachment 8668996 [details]
> New errors after fixing checkResponse()
Added debug:
> ADB Addon Helper: fileData.set(pkgData, 0);
|
Assignee | |
Comment 7•9 years ago
|
||
I've got a complete fix, will post my own PR.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8668993 -
Flags: review?(jryans)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Attachment #8668993 -
Attachment is obsolete: true
Attachment #8669112 -
Flags: review?(poirot.alex)
|
|
Reporter | |
Comment 9•9 years ago
|
||
Great! I'll test this locally :).
|
|
Reporter | |
Comment 10•9 years ago
|
||
Comment on attachment 8669112 [details]
Repair pull / push for Gecko 43+
Looks like it fixes the issue on my side too! Thanks!
Attachment #8669112 -
Flags: feedback+
|
||
Comment 11•9 years ago
|
||
Comment on attachment 8669112 [details]
Repair pull / push for Gecko 43+
Good catch, Thanks!
Attachment #8669112 -
Flags: review?(poirot.alex) → review+
|
|
Assignee | |
Comment 12•9 years ago
|
||
Merged: https://github.com/mozilla/adbhelper/commit/f662242e08f00995434d752f788d21a1b344d65a
Will start preparing 0.8.2 release.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 13•9 years ago
|
||
0.8.2 released. May take up to 24 hours to appear available.
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•