Closed
Bug 1216362
Opened 9 years ago
Closed 9 years ago
include mAttrList in memory measurements of nsCSSSelectors
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
|
(deleted),
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
In bug 1162535 comment 14 erahm found that nsAttrList objects were contributing significantly to dark memory, so we should measure them.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8676011 -
Attachment is patch: true
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8676011 [details] [diff] [review]
patch
Review of attachment 8676011 [details] [diff] [review]:
-----------------------------------------------------------------
r=me after fixing the |mValue| measurement.
::: layout/style/StyleRule.cpp
@@ +292,5 @@
> + size_t n = 0;
> + const nsAttrSelector* p = this;
> + while (p) {
> + n += aMallocSizeOf(p);
> + n += mValue.SizeOfExcludingThisIfUnshared(aMallocSizeOf);
This is going just keep measuring this->mValue. I think you want p->mValue.
Attachment #8676011 -
Flags: review?(erahm) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•