Closed
Bug 1216747
Opened 9 years ago
Closed 9 years ago
nsRuleNode::ComputePositionData caches writing-mode-specific data in the rule tree
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla44
| Tracking | Status | |
|---|---|---|
| firefox44 | --- | fixed |
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(3 files)
|
(deleted),
text/html
|
Details | |
|
(deleted),
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
Bug 1122253 added code that computes an nsStylePosition struct in ways that depend on the writing mode, and then caches that struct in the rule tree. This causes the cached struct to be used incorrectly.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dbaron
|
|
Assignee | |
Comment 2•9 years ago
|
||
Without the patch, both reftests fail; with it, both pass.
Attachment #8676490 -
Flags: review?(cam)
|
||
Updated•9 years ago
|
Attachment #8676490 -
Flags: review?(cam) → review+
|
|
||
Comment 3•9 years ago
|
||
I wonder if it would be worth trying to add assertions that fire if mWritingMode or mFont.size are used and conditions isn't updated appropriately. (It would need some trickiness like exposing those values only through methods on style structs, and also returning them as an object that supports conversion to their actual type, so that we could know when their values are actually used, as opposed to just retrieved.)
|
|
Assignee | |
Comment 5•9 years ago
|
||
(In reply to Cameron McCormack (:heycam) from comment #3)
> I wonder if it would be worth trying to add assertions that fire if
At first glance, it sounds like more trouble than it's worth.
|
|
Assignee | |
Comment 7•9 years ago
|
||
Attachment #8676691 -
Flags: review?(cam)
|
|
||
Updated•9 years ago
|
Attachment #8676691 -
Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/eae93d445958
https://hg.mozilla.org/mozilla-central/rev/0bcf20224e95
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
|
||
Comment 10•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•