Comment on attachment 8679827 [details] [diff] [review] Make the FasterMake backend reticulate splines when moz.build or jar.mn files are modified >+ # Add backend dependencies: >+ mk.create_rule([self._backend_output_list_file]).add_dependencies( >+ self.backend_input_files) What is this used for? As far as I can tell, it seems to behave the same without it. Namely, the backend.RecursiveMakeBackend rule triggers when backend_input_files changes, which regenerates the faster-make backend as well. Looks good otherwise, if I'm understanding it correctly.

self.backend_iunput_files contains more files in the fastermake backend, so there are effectively more files that can trigger splines reticulations for that backend compared to the recursive make backend. And those are not actual dependencies for the recursive make backend either.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e22433400ec2 https://hg.mozilla.org/integration/mozilla-inbound/rev/b855984ff056

Backed out to hopefully fix the Win PGO bustage so I can merge inbound. https://hg.mozilla.org/integration/mozilla-inbound/rev/9bd43c8ec7be https://hg.mozilla.org/integration/mozilla-inbound/rev/d0da0df3ed52

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec7ac102bcb9 https://hg.mozilla.org/integration/mozilla-inbound/rev/28116363f21a

https://hg.mozilla.org/mozilla-central/rev/ec7ac102bcb9 https://hg.mozilla.org/mozilla-central/rev/28116363f21a

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ec7ac102bcb9 https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/28116363f21a

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion