Closed
Bug 1217377
Opened 9 years ago
Closed 9 years ago
(Gaia RTL 2.5) CSS refactoring: Callscreen
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S11 (13Nov)
People
(Reporter: pelloux, Assigned: pelloux)
References
Details
Attachments
(1 file)
This bug is for the CSS refactoring of the Callscreen app, following the new BiDi guidelines.
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8680034 [details]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master
Hi Gabriele,
Could you review this PR please?
Attachment #8680034 -
Flags: review?(gsvelto)
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8680034 [details]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master
Looks good to me, thanks!
Attachment #8680034 -
Flags: review?(gsvelto) → review+
Keywords: checkin-needed
|
||
Comment 7•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S11 (13Nov)
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8680034 [details]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): None
[User impact] if declined: Bad rtl experience for callscreen
[Testing completed]: on flame
[Risk to taking this patch] (and alternatives if risky): medium because the patch is big. There is no alternative to support RTL for the callscreen.
[String changes made]: none.
Attachment #8680034 -
Flags: approval-gaia-v2.5?
|
|
||
Comment 9•9 years ago
|
||
Comment on attachment 8680034 [details]
[gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master
Clearing uplift as it is already in 2.5
Attachment #8680034 -
Flags: approval-gaia-v2.5?
|
||
Comment 10•9 years ago
|
||
(In reply to Augustin Trancart [:autra] from comment #9)
> Comment on attachment 8680034 [details]
> [gaia] Phoxygen:bug1217377-callscreen-rtl-css > mozilla-b2g:master
>
> Clearing uplift as it is already in 2.5
I saw the commits on github history (Commits on Oct 28, 2015), but the patch doesn't work.
The action buttons on the dialer screen are at the same location.
Please refer to the bug 1217755.
You need to log in
before you can comment on or make changes to this bug.
Description
•