Closed
Bug 1217730
Opened 9 years ago
Closed 9 years ago
Duplicated home screens shown as separate home screens
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: twen, Assigned: gmarty)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
When user installs twice of the same home screen via webIDE, it will create two home screens of the same name in the selection menu.
[Repro Steps]:
1. Install a home screen from webIDE
2. Install the same home screen again
3. Observe Settings -> Home Screens -> Change Home Screen -> home screens selection menu
[Actual Result]:
Two home screens of the same name
[Expected Result]:
Only one home screen in the menu
[Build Info]:
Build ID 20151023005002
Gaia Revision 29ce8ec8606e59f582375234440812b046346513
Gaia Date 2015-10-22 05:31:38
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/1f03a14106e59280761ac53904340f389674337f
Gecko Version 44.0a1
Device Name aries
Firmware(Release) 4.4.2
Firmware(Incremental) eng.worker.20151023.001128
Firmware Date Fri Oct 23 00:11:35 UTC 2015
Bootloader s1
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Comment 1•9 years ago
|
||
Nominate for blocking because it creates another bug 1217734.
blocking-b2g: --- → 2.5?
Comment 2•9 years ago
|
||
Hey, let's try to be at least somewhat accurate with these components, eh? :)
Homescreen apps are not involved in the process of installing homescreens, application settings or displaying settings. I've moved this to Settings for investigation.
Component: Gaia::Homescreen → Gaia::Settings
Updated•9 years ago
|
Whiteboard: [systemsfe]
Comment 3•9 years ago
|
||
I suspected its WebIDE issue but it does not happen on addon. So there might be some issues when we filter out the homescreen list.
@gmarty do you have time to investigate with this?
Flags: needinfo?(gmarty)
Comment 4•9 years ago
|
||
I'm almost certain this is caused by WebIDE generating a new manifestURL that is different than the one the gaia build system gives the homescreen. In any case, not blocking since it is something only a developer will see and can easily work around.
blocking-b2g: 2.5? → ---
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → gmarty
Flags: needinfo?(gmarty)
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8679453 [details]
[gaia] gmarty:Bug-1217730-Duplicated-home-screens-shown-as-separate-home-screens > mozilla-b2g:master
I fixed this bug by checking if an app is not already installed before adding it to the list of apps. I also wrote a unit test. Fred, can you take a look at this PR please?
Attachment #8679453 -
Flags: review?(gasolin)
Comment 7•9 years ago
|
||
Comment on attachment 8679453 [details]
[gaia] gmarty:Bug-1217730-Duplicated-home-screens-shown-as-separate-home-screens > mozilla-b2g:master
looks good with 1 thing in github comment. Thanks!
Attachment #8679453 -
Flags: review?(gasolin) → review+
Comment 8•9 years ago
|
||
[Blocking Requested - why for this release]:influence homescreen install experience
blocking-b2g: --- → 2.5?
Comment 9•9 years ago
|
||
Agree with Michael and not affecting users. Removing nomination.
blocking-b2g: 2.5? → ---
Assignee | ||
Comment 10•9 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/75f2236d36cc9f9c02d3596fae3de014007cfd82
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•9 years ago
|
||
Verified fixed. Same home screen no longer appears as separate home screens.
Build ID 20151101012023
Gaia Revision 91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date 2015-10-28 20:32:15
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/96377bdbcdf3e444a22aeaa677da696243b00d98
Gecko Version 45.0a1
Device Name aries
Firmware(Release) 4.4.2
Firmware(Incremental) eng.worker.20151101.004008
Firmware Date Sun Nov 1 00:40:17 UTC 2015
Bootloader s1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•