Closed
Bug 1220528
Opened 9 years ago
Closed 9 years ago
Configure the default build flag FIREFOX_SYNC to ENABLE in v2.5 branch, TV only
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)
Tracking
(b2g-v2.5 fixed)
RESOLVED
FIXED
FxOS-S11 (13Nov)
Tracking | Status | |
---|---|---|
b2g-v2.5 | --- | fixed |
People
(Reporter: selee, Assigned: selee)
References
Details
(Whiteboard: [partner-cherry-pick])
Attachments
(2 files, 1 obsolete file)
Since FirefoxSync feature is a must in gaia v2.5, the default build flag FIREFOX_SYNC should be configured as ENABLE.
Assignee | ||
Comment 1•9 years ago
|
||
This will be only happened in v2.5 gaia branch.
Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → FxOS-S11 (13Nov)
Updated•9 years ago
|
Summary: Configure the default build flag FIREFOX_SYNC to ENABLE in v2.5 branch. → Configure the default build flag FIREFOX_SYNC to ENABLE in v2.5 branch, TV only
Updated•9 years ago
|
Assignee: nobody → ferjmoreno
Target Milestone: FxOS-S11 (13Nov) → FxOS-S10 (30Oct)
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Assignee | ||
Updated•9 years ago
|
Attachment #8681801 -
Attachment is obsolete: true
Assignee | ||
Comment 5•9 years ago
|
||
Thank you Fernando! I will modify the patch. :)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8681802 [details]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5
Hey Ricky, Fernando, Could you give a review/feedback for this patch? Thank you!
Attachment #8681802 -
Flags: review?(rchien)
Attachment #8681802 -
Flags: feedback?(ferjmoreno)
Comment 7•9 years ago
|
||
Comment on attachment 8681802 [details]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5
LGTM. Thanks!
Attachment #8681802 -
Flags: feedback?(ferjmoreno) → feedback+
Assignee | ||
Updated•9 years ago
|
Target Milestone: FxOS-S10 (30Oct) → FxOS-S11 (13Nov)
Comment 8•9 years ago
|
||
Comment on attachment 8681802 [details]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5
Hmm... it looks good to me. thanks for separating device makefile, it will be useful for support various form factor in the future.
Attachment #8681802 -
Flags: review?(rchien) → review+
Comment hidden (obsolete) |
Assignee | ||
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 10•9 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
Comment on attachment 8681802 [details]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1194108
[User impact] if declined: Developer has to use build flag FIREFOX_SYNC=1 to enable Firefox Sync feature in TV.
[Testing completed]: Tested in B2G Desktop
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none
Attachment #8681802 -
Flags: approval-gaia-v2.5?
Comment 12•9 years ago
|
||
Can you please update the bug to resolved and fixed, and I can approve the uplift.
Thanks
Flags: needinfo?(selee)
Assignee | ||
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Flags: needinfo?(selee)
Resolution: --- → FIXED
Comment 13•9 years ago
|
||
Comment on attachment 8681802 [details]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5
Approved for 2.5 uplift
Attachment #8681802 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Comment 14•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/91e1047a80f1207c2af924a38f292141c647a250
btw, just in case, this never landed on gaia master so far (the 2nd Pull request) does this still need to land there ?
status-b2g-v2.5:
--- → fixed
Flags: needinfo?(selee)
Assignee | ||
Comment 15•9 years ago
|
||
Hi Tomcat, Thanks for your remind. :) I think the patch for master is good enough to land. However, it still needs a r+.
Flags: needinfo?(selee)
Assignee | ||
Comment 16•9 years ago
|
||
Comment on attachment 8684854 [details]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1220528 > mozilla-b2g:master
Hi Ricky, Could you help to review the patch for master? The difference with v2.5 one is only at FIREFOX_SYNC default value. Thank you!
Attachment #8684854 -
Flags: review?(rchien)
Updated•9 years ago
|
Attachment #8684854 -
Flags: review?(rchien) → review+
Assignee | ||
Comment 17•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•