Closed
Bug 1220732
Opened 9 years ago
Closed 9 years ago
Enable some already-working DOM browser-chrome e10s tests
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Updated•9 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Assignee | ||
Comment 1•9 years ago
|
||
browser_swapDocShells.js cites bug 918634, which has been fixed.
browser_bug134911.js says "BrowserSetForcedCharacterSet() in browser.js references docShell". It looks like this was fixed in bug 999293.
Many of these say "event handler checks event.target is the content document and test e10s-utils doesn't do that", but I asked billm about it and he said that has been fixed.
browser_bug388121-2.js: This says "test touches content (newBrowser.contentDocument.nodePrincipal)" but the test does not actually contain that code. It looks like it is touching nodePrincipal on an about:blank document, so maybe that's in the parent process? I could leave this test disabled if it needs more analysis.
browser_bug420605.js: This says "Bug 933103 - mochitest's EventUtils.synthesizeMouse functions not e10s friendly". It looks like that was fixed for bc tests in bug 1131818.
I filed bugs and cited them for a few tests that fail in a different way than the description says.
I fixed browser_bug852909.js. The only problem was that it wasn't using a shim to get mayEnableCharacterEncodingMenu.
I didn't look into why the IndexedDB tests use to fail and now don't. One still fails for a reason unrelated to IndexedDB, and I filed a bug for that.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=244e4a566f10
bc1 is permaorange in a test at the end of dom/base/test, but I've re-disabled a test I enabled in that directory, so hopefully it will be okay.
Attachment #8682575 -
Flags: review?(mrbkap)
Updated•9 years ago
|
Attachment #8682575 -
Flags: review?(mrbkap) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 3•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•