Closed
Bug 1221103
Opened 9 years ago
Closed 9 years ago
Add a comment to nsIChannel::securityInfo noting that this info may appear on non-nsHttpChannels and how that may happen
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
Details
Attachments
(1 file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
It wasn't obvious to me, but nsIChannel::securityInfo may be set for documents that didn't come directly from a network request. For example, document.open written documents, which use an nsWyciwygChannel, have the security info from their entry settings object passed on to their nsWyciwygChannel. Details:
We grap the security info from the document.open caller:
https://mxr.mozilla.org/mozilla-central/source/dom/html/nsHTMLDocument.cpp?rev=cba6ff5bd32b&mark=1466-1469,1484-1484#1466
store it and call CreateAndAddWyciwygChannel():
https://mxr.mozilla.org/mozilla-central/source/dom/html/nsHTMLDocument.cpp?rev=cba6ff5bd32b&mark=1667-1667,1712-1712#1665
which propagates the security info onto the nsWyciwygChannel:
https://mxr.mozilla.org/mozilla-central/source/dom/html/nsHTMLDocument.cpp?rev=cba6ff5bd32b&mark=2410-2410#2410
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8682503 -
Flags: review?(bzbarsky)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8682503 [details] [diff] [review]
patch
r=me
Attachment #8682503 -
Flags: review?(bzbarsky) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•