Closed
Bug 1221459
Opened 9 years ago
Closed 9 years ago
Remove TouchCaret and SelectionCarets
Categories
(Core :: DOM: Selection, defect)
Core
DOM: Selection
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(4 files)
AccessibleCaret obsoletes TouchCaret and SelectionCaret. We can remove them after fennec migrates to AccessibleCaret.
We might want to remove SelectionStateChanged event as well since it's only used by TouchCaret and SelectionCaret.
|
||
Comment 1•9 years ago
|
||
I'm very happy to see this happened. \o/
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → tlin
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28477/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28477/
Attachment #8699910 -
Flags: review?(mtseng)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28479/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28479/
Attachment #8699911 -
Flags: review?(mtseng)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28481/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28481/
Attachment #8699912 -
Flags: review?(mtseng)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/28483/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28483/
Attachment #8699913 -
Flags: review?(mtseng)
|
|
Assignee | |
Comment 6•9 years ago
|
||
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8699910 [details]
MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng, r=roc
https://reviewboard.mozilla.org/r/28477/#review25501
Attachment #8699910 -
Flags: review?(mtseng) → review+
|
|
||
Updated•9 years ago
|
Attachment #8699911 -
Flags: review?(mtseng) → review+
|
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8699911 [details]
MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files. r=mtseng, r=roc
https://reviewboard.mozilla.org/r/28479/#review25503
|
|
||
Comment 9•9 years ago
|
||
Comment on attachment 8699912 [details]
MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets from marionette tests. r=mtseng
https://reviewboard.mozilla.org/r/28481/#review25505
Attachment #8699912 -
Flags: review?(mtseng) → review+
|
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8699913 [details]
MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
https://reviewboard.mozilla.org/r/28483/#review25507
::: b2g/chrome/content/shell.js
(Diff revision 1)
> - DoCommandHelper.setEvent(evt);
DoCommandHelper can be removed completely.
Attachment #8699913 -
Flags: review?(mtseng)
|
|
Assignee | |
Comment 11•9 years ago
|
||
Comment on attachment 8699910 [details]
MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng, r=roc
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28477/diff/1-2/
Attachment #8699910 -
Attachment description: MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets → MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets. f=mtseng, r=roc
Attachment #8699910 -
Flags: review?(roc)
|
|
Assignee | |
Comment 12•9 years ago
|
||
Comment on attachment 8699911 [details]
MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files. r=mtseng, r=roc
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28479/diff/1-2/
Attachment #8699911 -
Attachment description: MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files → MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files. f=mtseng, r=roc
Attachment #8699911 -
Flags: review?(roc)
|
|
Assignee | |
Comment 13•9 years ago
|
||
Comment on attachment 8699912 [details]
MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets from marionette tests. r=mtseng
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28481/diff/1-2/
Attachment #8699912 -
Attachment description: MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets from marionette tests → MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets from marionette tests. f=mtseng, r=automatedtester
Attachment #8699912 -
Flags: review?(dburns)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8699913 -
Attachment description: MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent → MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. f=mtseng, r=smaug
Attachment #8699913 -
Flags: review?(bugs)
|
|
Assignee | |
Comment 14•9 years ago
|
||
Comment on attachment 8699913 [details]
MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28483/diff/1-2/
|
|
Assignee | |
Comment 15•9 years ago
|
||
Comment on attachment 8699913 [details]
MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28483/diff/2-3/
|
||
Comment 16•9 years ago
|
||
Comment on attachment 8699913 [details]
MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
https://reviewboard.mozilla.org/r/28483/#review25537
Attachment #8699913 -
Flags: review?(bugs) → review+
Comment on attachment 8699910 [details]
MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng, r=roc
https://reviewboard.mozilla.org/r/28477/#review25587
Attachment #8699910 -
Flags: review?(roc) → review+
Comment on attachment 8699911 [details]
MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files. r=mtseng, r=roc
https://reviewboard.mozilla.org/r/28479/#review25589
Attachment #8699911 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8699910 -
Attachment description: MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets. f=mtseng, r=roc → MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng, r=roc
|
|
Assignee | |
Comment 19•9 years ago
|
||
Comment on attachment 8699910 [details]
MozReview Request: Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng, r=roc
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28477/diff/2-3/
|
|
Assignee | |
Comment 20•9 years ago
|
||
Comment on attachment 8699911 [details]
MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files. r=mtseng, r=roc
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28479/diff/2-3/
Attachment #8699911 -
Attachment description: MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files. f=mtseng, r=roc → MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets prefs in test files. r=mtseng, r=roc
|
|
Assignee | |
Comment 21•9 years ago
|
||
Comment on attachment 8699912 [details]
MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets from marionette tests. r=mtseng
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28481/diff/2-3/
Attachment #8699912 -
Attachment description: MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets from marionette tests. f=mtseng, r=automatedtester → MozReview Request: Bug 1121459 - Remove TouchCaret and SelectionCarets from marionette tests. r=mtseng
Attachment #8699912 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 22•9 years ago
|
||
Comment on attachment 8699913 [details]
MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28483/diff/3-4/
Attachment #8699913 -
Attachment description: MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. f=mtseng, r=smaug → MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
Attachment #8699913 -
Flags: review?(mtseng)
|
||
Comment 23•9 years ago
|
||
|
|
||
Comment 24•9 years ago
|
||
Comment on attachment 8699913 [details]
MozReview Request: Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
https://reviewboard.mozilla.org/r/28483/#review25627
Attachment #8699913 -
Flags: review?(mtseng) → review+
|
|
||
Comment 25•9 years ago
|
||
|
||
Comment 26•9 years ago
|
||
There's a typo in the commit message when referencing the bug, see bug 1121459 comment 1
|
||
Comment 27•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/85735791e2d254f407ceee79ba2dae7d5650d7f0
Backed out changeset c97319b5cb12 (bug 1221459)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d9914a3e5b18834102f52801fc11d33ec737d24
Backed out changeset 9f30d3caa231 (bug 1221459)
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c208d26dc1b1721a8685986e73c66eee5065848
Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng, r=roc
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a0eb24805cad5905912e6d2c6f1d4a7a14fa471
Bug 1221459 - Remove TouchCaret and SelectionCarets prefs in test files. r=mtseng, r=roc
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4236b2a3b36b4850f18d968c73556f17f7803f
Bug 1221459 - Remove TouchCaret and SelectionCarets from marionette tests. r=mtseng
https://hg.mozilla.org/integration/mozilla-inbound/rev/2876cc921266f8fddd7dceca4fd780ee471faf14
Bug 1221459 - Remove SelectionStateChangedEvent. r=mtseng, r=smaug
|
||
Comment 28•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8c208d26dc1b
https://hg.mozilla.org/mozilla-central/rev/3a0eb24805ca
https://hg.mozilla.org/mozilla-central/rev/ba4236b2a3b3
https://hg.mozilla.org/mozilla-central/rev/2876cc921266
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•