Closed
Bug 1223937
Opened 9 years ago
Closed 9 years ago
test_bug388794.html fails string match test due to off by one error in Fennec with C++APZ
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: rbarker, Assigned: rbarker)
References
Details
Attachments
(1 file)
When C++APZ is enabled in Fennec, events that are generated by nsWindowUtil may result in off by one errors when received by the DOM. This is caused by the fact that the PresShell resolution must be applied to the event coordinates before being dispatched which introduces rounding errors. To work around the failure in test_bug388794.html it is necessary to convert the string compares to regex so that the off by one rounding errors may be accounted for.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → rbarker
Assignee | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Can we fix this by adding a meta-viewport tag to the test such that the resolution is always 1.0?
Updated•9 years ago
|
Comment 3•9 years ago
|
||
Comment on attachment 8686225 [details] [diff] [review]
0001-Bug-1223937-test_bug388794.html-fails-string-match-test-due-to-off-by-one-error-in-Fennec-with-C-APZ-15111112-201e8cf.patch
roc, we'd like to land this to fix this test on Fennec with the C++ APZ. There's rounding errors caused by the resolution. The other alternative is to just disable the test on Fennec.
Attachment #8686225 -
Flags: review?(roc)
Comment 4•9 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> Can we fix this by adding a meta-viewport tag to the test such that the
> resolution is always 1.0?
(For the record, the problem with this is that the test runs inside an iframe in the harness, and so meta-viewport tags don't make a difference. At least that's what we think.. haven't tried it)
Attachment #8686225 -
Flags: review?(roc) → review+
Comment 6•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•