Closed
Bug 1224237
Opened 9 years ago
Closed 9 years ago
Remove the !baseURL check from ServiceWorkerContainer::Register
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: ejpbruel, Assigned: ejpbruel)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bkelly
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As per discussion on irc.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8686638 -
Flags: review?(bkelly)
Comment 2•9 years ago
|
||
To clarify, the check is unneeded as relative script and scopes will just fail at the NS_NewURI() calls if the baseURI is nullptr. Allowing nullptr baseURI permits us to use serviceWorker.register() with absolute URIs in test frame scripts where there is no document.
Updated•9 years ago
|
Attachment #8686638 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 3•9 years ago
|
||
This patch is simple enough that we can risk landing it without a try push.
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment 6•9 years ago
|
||
Comment on attachment 8686638 [details] [diff] [review]
Patch to be reviewed.
Approval Request Comment
[Feature/regressing bug #]: Service workers
[User impact if declined]: This is needed to uplift bug 1223116.
[Describe test coverage new/current, TreeHerder]: Test in bug 1223116
[Risks and why]: Minimal. Only service workers.
[String/UUID change made/needed]: None.
Attachment #8686638 -
Flags: approval-mozilla-aurora?
status-firefox44:
--- → affected
Comment on attachment 8686638 [details] [diff] [review]
Patch to be reviewed.
Aurora44+, seems like it is needed for another uplift related to SW, which is planned for FF44.
Attachment #8686638 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•9 years ago
|
||
status-firefox43:
--- → wontfix
Comment 9•9 years ago
|
||
bugherder uplift |
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•