Closed
Bug 1224547
Opened 9 years ago
Closed 9 years ago
[Aries] test_gallery_view.py fails: AssertionError: 640 != 590
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
> Traceback (most recent call last):
> File "/var/jenkins/1/workspace/aries.mozilla-central.nightly.ui.functional.smoke/.env/local/lib/python2.7/site-packages/marionette_client-1.0.0-py2.7.egg/marionette/marionette_test.py", line 296, in run
> testMethod()
> File "/var/jenkins/1/workspace/aries.mozilla-central.nightly.ui.functional.smoke/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_view.py", line 46, in test_gallery_view
> self.assertEqual(self.device.screen_width, image.photo_toolbar_width)
> AssertionError: 640 != 590
|
Assignee | |
Comment 1•9 years ago
|
||
Found out the issue: the software home button is cropping a part of the screen which makes the value down to 590.
|
||
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8687200 [details]
[gaia] JohanLorenzo:bug-1224547 > mozilla-b2g:master
Tell me what you guys think.
Attachment #8687200 -
Flags: review?(npark)
Attachment #8687200 -
Flags: review?(martijn.martijn)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8687200 [details]
[gaia] JohanLorenzo:bug-1224547 > mozilla-b2g:master
Looks good other than the frame returning issue.
Attachment #8687200 -
Flags: review?(npark) → review+
|
||
Updated•9 years ago
|
Attachment #8687200 -
Flags: review?(martijn.martijn) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
(In reply to No-Jun Park [:njpark] from comment #4)
> Looks good other than the frame returning issue.
Discussed in the PR, we don't change that, for consistency for the other methods of the class.
Landed in master at: https://github.com/mozilla-b2g/gaia/commit/4562b5600b3344b4c72564c0dc139a05ce45f740
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•