see jonas' comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1209162#c27

PrincipalOriginAttributes will be initialized with default value, appId=0 and inBrowser=false. And gfxSVGGlyphsDocument seems not related to any origin attributes-specific things, so the code in https://dxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxSVGGlyphs.cpp#351 should be no harm, Jonas, do you agree? Thanks

If the gfxSVGGlyphsDocument makes any network requests (to download subresources) we'll need it to have the right origin attributes so that it uses the right cookies when making those network requests. Similarly if the document does any sort of permission checks, we'll want to make sure that those checks use the right permissions. In general, I would be very worried that if we have an incorrect principal here we'll end up in trouble either now or in the future. It just feels very unsafe to do. If we truly don't think that this document will ever need to make network requests or check permissions, then we should use a nullprincipal instead.

Hi, Edwin You changed to use a non-null principal back in bug 801467, and now I tried to move the null principal back and the tests looks okay, can you help to check if we can use null principal now? Thanks

Comment on attachment 8721231 [details] [diff] [review] Patch Review of attachment 8721231 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Yoshi Huang[:allstars.chh] from comment #3) > You changed to use a non-null principal back in bug 801467, and now I tried > to move the null principal back and the tests looks okay, can you help to > check if we can use null principal now? Hm, no idea why I did that. This makes sense AFAICT from the spec, which states that rendering be done with "no script execution, external references, interactivity, or link traversal."

Comment on attachment 8721231 [details] [diff] [review] Patch Review of attachment 8721231 [details] [diff] [review]: ----------------------------------------------------------------- Hi Edwin Ask for r? for the same patch, as it looks changing to use null principal should be enough. I'd change patch subject later. Thanks

https://hg.mozilla.org/integration/mozilla-inbound/rev/e46b452357990be9b9838e13086e277bedda077b Bug 1225053 - use null principal in gfxSVGGlyphs.cpp r=edwin