Closed
Bug 1226130
Opened 9 years ago
Closed 9 years ago
"Clear private data on exit" option is visible in restricted profile
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox45 verified, fennec45+)
RESOLVED
FIXED
Firefox 45
People
(Reporter: u549602, Assigned: sebastian)
References
Details
Attachments
(2 files)
Environment: Nightly
Device: Sony Xperia Z2 (Android 5.0.2);
Build: Nightly 45.0a1 (2015-11-18);
Steps to reproduce:
1. Owner sets "Clear private data" to disabled
2. User logs in Restricted profile and visits Settings - Privacy
Expected result:
"Clear private data on exit" option is not visible in the Privacy menu
Actual result:
"Clear private data on exit" option is available in the Privacy menu and functions as it wasn't disabled
For further details please check: https://www.youtube.com/watch?v=3GoiWowsH1U&feature=youtu.be
Updated•9 years ago
|
tracking-fennec: --- → ?
Comment 1•9 years ago
|
||
This is probably a regression from the settings reorg work...
Blocks: 1216257
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1226130 - GeckoPreferences: Process PrefHandlers last. r?margaret
A restriction might remove the preference, so we want to remove it first and only
call the PrefsHandler if the preference is still visible.
Attachment #8692958 -
Flags: review?(margaret.leibovic)
Comment 3•9 years ago
|
||
Comment on attachment 8692958 [details]
MozReview Request: Bug 1226130 - GeckoPreferences: Process PrefHandlers last. r?margaret
https://reviewboard.mozilla.org/r/26365/#review23817
::: mobile/android/base/preferences/GeckoPreferences.java:857
(Diff revision 1)
> + PrefHandler handler = handlers.get(key);
It could be good to leave a comment here about why we want to do this last.
Attachment #8692958 -
Flags: review?(margaret.leibovic) → review+
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/19c3d08e8304f13070270c23bd099c0179494255
Bug 1226130 - GeckoPreferences: Process PrefHandlers last. r=margaret
Comment 5•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
tracking-fennec: ? → 45+
Please note that the dependency on bug 1230937 is still valid since the crash when launching Aurora in restricted profile reproduces. Also, this issue could not be verified on Aurora and a new issue ( https://bugzilla.mozilla.org/show_bug.cgi?id=1234185 ) was added for the new Nightly build (46.0a1) on which the "clear data on exit" option displayed in restricted profile still could be reproduced.
Verified as fixed on the latest Aurora build (45.0a2 07-01-2016), on a Samsung Galaxy Tab S2 with Android 5.0.2
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•