With native APZ turned on, I'm unable to zoom after the following: 1) Open Fennec, navigate to nytimes.com 2) Ater load, open https://bluemarvin.github.io/html/iframe.html via adb I can't zoom iframe.html, when I should in fact be able to.

Comment on attachment 8689686 [details] [diff] [review] Fix some bustage from refactoring APZ tree traversal Review of attachment 8689686 [details] [diff] [review]: ----------------------------------------------------------------- LGTM, but Botond should probably be the one to review it.

Comment on attachment 8689686 [details] [diff] [review] Fix some bustage from refactoring APZ tree traversal Review of attachment 8689686 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, this part of the refactoring didn't preserve the semantics perfectly. My bad for not catching that during review! However, this patch doesn't quite restore the original semantics, either. - Before the refactor, we would do the "is primary holder" check on every node, and the "skip the subtree" check on every node except the starting node. - The refactor changed it so we call the "skip the subtree" check on the starting node, too, and since we do that before the "is primary holder" check, we can end up skipping the entire subtree of the starting node, which is not desirable. - This patch changes it so that we do an extra "is primary holder" check on the starting node, but we still do t he "skip the subtree" check afterward so it can still fire. I believe the correct solution here it to omit the "skip the subtree" check for the starting node. I can submit a patch that does this.

Bug 1226320 - Fix a refactoring in APZCTreeManager that didn't preserve semantics correctly. r=kats

Comment on attachment 8689699 [details] MozReview Request: Bug 1226320 - Fix a refactoring in APZCTreeManager that didn't preserve semantics correctly. r=kats https://reviewboard.mozilla.org/r/25693/#review23133