Flash on Android is unsupported and will never be updated again. It is potentially causing intermittent crashes on several tests which only serve to increase orange. Since we do want to test if we break overall Flash functionality, we should limit Flashes use to the Autophone Robocop Flash test.

The flash files will have to be manually copied into the new apk directory.

Comment on attachment 8695196 [details] [diff] [review] bug-1229807-v1.patch Review of attachment 8695196 [details] [diff] [review]: ----------------------------------------------------------------- Consider updating one of the docs to mention when the flash apks are needed and where they need to be. ::: tests/runtestsremote.py @@ +124,4 @@ > self.chunk, > self.parms['phoneid']) > > + if self.parms['test_name'] == 'robocoptest-autophone': I was thinking that you might avoid this ugliness by adding an "extra-apk" setting to the test configuration. But you would need settings for the apk name and package name and then still need to deal with build version differences...so it's probably better to handle it this way.

(In reply to Geoff Brown [:gbrown] from comment #2) > Comment on attachment 8695196 [details] [diff] [review] > bug-1229807-v1.patch > > Review of attachment 8695196 [details] [diff] [review]: > ----------------------------------------------------------------- > > Consider updating one of the docs to mention when the flash apks are needed > and where they need to be. > will do. > ::: tests/runtestsremote.py > @@ +124,4 @@ > > self.chunk, > > self.parms['phoneid']) > > > > + if self.parms['test_name'] == 'robocoptest-autophone': > > I was thinking that you might avoid this ugliness by adding an "extra-apk" > setting to the test configuration. But you would need settings for the apk > name and package name and then still need to deal with build version > differences...so it's probably better to handle it this way. Yeah, I started down that path and quickly realized I didn't want to go farther.