Closed
Bug 1235535
Opened 9 years ago
Closed 9 years ago
[Testcase] Split the audio channel muted-by-default test from "test_browserElement_inproc/oop_AudioChannel.html."
Categories
(Firefox OS Graveyard :: AudioChannel, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(2 files)
Split the muted-by-default test case out from test_browserElement_inproc/oop_AudioChannel.html.
In this bug, I want to solve following problems,
(1) Improve the drawback of the previous implementation
Modify some codes in order to let the test message more clear.
(2) Reduce time-out probability
The test case becomes more often time-out recently after landing bug1223298.
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29121/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29121/
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/29123/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29123/
Assignee | ||
Comment 3•9 years ago
|
||
[Correct the description]
(2) Reduce time-out probability
The test case becomes more often time-out recently after landing "bug1223261".
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29121/diff/1-2/
Attachment #8702532 -
Flags: review?(amarchesini)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29123/diff/1-2/
Attachment #8702533 -
Flags: review?(amarchesini)
Assignee | ||
Comment 7•9 years ago
|
||
Hi, Baku,
Could you help me review this patch?
Very appreciate!
---
The purpose of this patch are,
(1) Improve the drawback of the previous implementation
Modify some codes in order to let the test message more clear.
(2) Reduce time-out probability
The test case becomes more often time-out recently after landing "bug1223261".
Updated•9 years ago
|
Attachment #8702533 -
Flags: review?(amarchesini) → review+
Comment 8•9 years ago
|
||
Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.
https://reviewboard.mozilla.org/r/29123/#review25993
Updated•9 years ago
|
Attachment #8702532 -
Flags: review?(amarchesini) → review+
Comment 9•9 years ago
|
||
Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.
https://reviewboard.mozilla.org/r/29121/#review25995
Comment 11•9 years ago
|
||
Hi, this failed to apply:
applying 9d7ec1f8877c
9d7ec1f8877c transplanted to 8e57ce8b2671
applying 592e70e87fcb
patching file dom/browser-element/mochitest/mochitest.ini
Hunk #3 FAILED at 137
1 out of 4 hunks FAILED -- saving rejects to file dom/browser-element/mochitest/mochitest.ini.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue
Flags: needinfo?(alwu)
Keywords: checkin-needed
Assignee | ||
Updated•9 years ago
|
Attachment #8702532 -
Attachment description: MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. → MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29121/diff/1-2/
Assignee | ||
Updated•9 years ago
|
Attachment #8702533 -
Attachment description: MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. → MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.
Assignee | ||
Comment 13•9 years ago
|
||
Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29123/diff/1-2/
Assignee | ||
Comment 14•9 years ago
|
||
Rebase, thanks!
Flags: needinfo?(alwu) → needinfo?(cbook)
Keywords: checkin-needed
Comment 15•9 years ago
|
||
Hi, still has problems it seems
applying 8e0b6d5ad2b5
patching file dom/browser-element/mochitest/mochitest.ini
Hunk #3 FAILED at 137
1 out of 4 hunks FAILED -- saving rejects to file dom/browser-element/mochitest/mochitest.ini.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue
Flags: needinfo?(cbook) → needinfo?(alwu)
Keywords: checkin-needed
Assignee | ||
Comment 16•9 years ago
|
||
Comment on attachment 8702532 [details]
MozReview Request: Bug 1235535 - part1 : remove muted-by-default test. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29121/diff/2-3/
Assignee | ||
Comment 17•9 years ago
|
||
Comment on attachment 8702533 [details]
MozReview Request: Bug 1235535 - part2 : create muted-by-default test in another new file. r=baku.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29123/diff/2-3/
Assignee | ||
Comment 18•9 years ago
|
||
Hi, Carsten,
Could you help me try it again?
I rebased this patch on the following version,
Very appreciate!
changeset: 278453:29258f59e545
tag: qparent
parent: 278332:6e01570011a6
parent: 278452:fc4fd9433e21
user: Carsten "Tomcat" Book <cbook@mozilla.com>
date: Tue Jan 05 11:58:56 2016 +0100
summary: merge mozilla-inbound to mozilla-central a=merge
Flags: needinfo?(alwu)
Keywords: checkin-needed
Comment 19•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0beb3e22b4b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/76209c880c78
Keywords: checkin-needed
Something from this push broke weightmapping-12579.html on OSX 10.10: https://treeherder.mozilla.org/logviewer.html#?job_id=19315024&repo=mozilla-inbound
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/9f1486908504
Flags: needinfo?(alwu)
Comment 21•9 years ago
|
||
Comment 22•9 years ago
|
||
bugherder |
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(alwu)
You need to log in
before you can comment on or make changes to this bug.
Description
•