Closed
Bug 1239207
Opened 9 years ago
Closed 9 years ago
IPDL should not be processed during artifact/disable-compile-environment builds
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: gps, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
On my Linux i7-6700K machine, `mach build` with artifacts takes ~52s (with the binary archive already downloaded). During the export tier, we have 2 long tails: WebIDL and IPDL processing. IPDL appears to be the slightly longer tail, taking ~9.4s to run.
I really don't think we need to be processing IPDL files when we're not doing C++ foo. This should make artifact builds a bit faster.
Reporter | ||
Comment 1•9 years ago
|
||
IPDL processing takes ~9.4s on my i7-6700K and is the long pole in the
"export" tier for clobber --disable-compile-environment builds. IPDL
shouldn't be needed for these builds.
Disabling IPDL makes artifact builds ~4s faster on my machine.
Review commit: https://reviewboard.mozilla.org/r/30629/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30629/
Attachment #8707290 -
Flags: review?(mh+mozilla)
Comment 2•9 years ago
|
||
Comment on attachment 8707290 [details]
MozReview Request: Bug 1239207 - Don't process IPDL when not compiling; r=glandium
https://reviewboard.mozilla.org/r/30629/#review27829
::: ipc/ipdl/Makefile.in:14
(Diff revision 1)
> +ifdef COMPILE_ENVIRONMENT
Might as well move this above the ipdlsrcs.mk include.
Attachment #8707290 -
Flags: review?(mh+mozilla) → review+
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8707290 [details]
MozReview Request: Bug 1239207 - Don't process IPDL when not compiling; r=glandium
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30629/diff/1-2/
Attachment #8707290 -
Attachment description: MozReview Request: Bug 1239207 - Don't process IPDL when not compiling; r?glandium → MozReview Request: Bug 1239207 - Don't process IPDL when not compiling; r=glandium
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•