Closed
Bug 1247782
Opened 9 years ago
Closed 4 years ago
Remove GeckoApp.createHealthRecorder & usages
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: mcomella, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
Details |
It appears we missed them when we implemented bug 1183320.
Reporter | ||
Comment 1•9 years ago
|
||
It seems we missed this when we implemented bug 1183320.
There was a FENNEC_WAS_KILLED histogram that used the SessionInformation - this
changeset maintains this functionality by pulling the access out of
SessionInformation and directly into GeckoApp, removing the SessionInformation
class.
Review commit: https://reviewboard.mozilla.org/r/34639/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34639/
Attachment #8718620 -
Flags: review?(rnewman)
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → michael.l.comella
Reporter | ||
Comment 2•9 years ago
|
||
fwiw, I didn't check that the FENNEC_WAS_KILLED histogram is still correctly set up after FHR was removed (and this patch was removed, for that matter).
Comment 3•9 years ago
|
||
I initially removed these parts in bug 1183320, but Richard asked that we keep them so session tracking for "core" ping had a roadmap/breadcrumbs that could be followed from the way FHR tracked session time.
Updated•9 years ago
|
Attachment #8718620 -
Flags: review?(rnewman)
Reporter | ||
Comment 5•9 years ago
|
||
I added the session recording for the core ping so we can delete this now.
Assignee: michael.l.comella → nobody
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Comment 6•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 4 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•