Closed
Bug 1247970
Opened 9 years ago
Closed 9 years ago
Remove principal spec from service worker registrar file
Categories
(Core :: DOM: Service Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1246319 +++
As discussed in bug 1246319, the principal spec often contains the full path of the registering document. We don't need this information since we only care about the origin itself. Since the origin is contained within the scope URL, we can drop the principal spec from the file.
This will save us a few bytes, but I think the main gain is removing redundant and confusing information.
Assignee | ||
Comment 1•9 years ago
|
||
This also limites dedupe to older schema versions. We assert there are no duplicates in debug builds always, though.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b79faf6ad17b
Attachment #8719602 -
Flags: review?(amarchesini)
Updated•9 years ago
|
Attachment #8719602 -
Flags: review?(amarchesini) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 3•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•