Closed
Bug 1253314
Opened 9 years ago
Closed 8 years ago
TC Linux 32 opt / PGO builds Tier-2
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla52
People
(Reporter: selenamarie, Assigned: mtabara)
References
Details
Attachments
(1 file)
This is a planning bug for tracking work related to getting Linux 32 Opt / PGO builds Tier-2.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mtabara
Assignee | ||
Updated•8 years ago
|
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
Note to self: Initially used the "old-fashioned way" approach as Linux64-PGO here[0] but failed due to Schema Validation Failed in "data.routes should NOT have more than 10 items" as per [1]. Removed the two index.buildbot.... routes and tried again at [2]. Eventually, adapted to the new build kind implementation under gecko/taskcluster and pushed patch.
@dustin
Do I need to tweak the coalescer[3] as well to reflect the linux32-pgo too?
[0]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4095e50f9a0&selectedJob=28022318
[1]: https://public-artifacts.taskcluster.net/SDO7F07pR-aDcirMv3nD4g/0/public/logs/live_backing.log
[2]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e53160cfe608
[3]: https://coalesce.mozilla-releng.net/v1/threshold
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8794600 [details]
Bug 1253314 - enable Linux32 PGO builds.
https://reviewboard.mozilla.org/r/80970/#review79748
Looks good!
Please rewrite the commit message -- I assume that's an `hg histedit` gone wrong :)
::: taskcluster/taskgraph/transforms/gecko_v2_whitelist.py:44
(Diff revision 1)
> 'linux64-pgo',
> 'linux64-st-an-opt',
> 'linux64-valgrind-opt',
> 'linux-debug',
> 'linux-opt',
> + 'linux-pgo',
Good, this matches
https://tools.taskcluster.net/index/#gecko.v2.mozilla-central.latest.firefox/gecko.v2.mozilla-central.latest.firefox.linux-pgo
Attachment #8794600 -
Flags: review?(dustin) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•8 years ago
|
||
@dustin: amended the commits message. Sorry again for folding instead of roling. Will keep that in mind.
When you have a spare minute, please land this for me as I don't have level3 to push to inbound.
Thanks!
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff35e4bcc7c8
enable Linux32 PGO builds. r=dustin
Comment 7•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/autoland/rev/47f858388a98 since what you got was https://treeherder.mozilla.org/logviewer.html#?job_id=4026208&repo=autoland
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•8 years ago
|
||
@dustin:
My bad, sorry for that, I forgot a trailing ".py" extension in the config file. I've reuploaded to review.
The same as yesterday, when reviewed - please land it for me.
Thanks!
Comment 10•8 years ago
|
||
mozreview-review |
Comment on attachment 8794600 [details]
Bug 1253314 - enable Linux32 PGO builds.
https://reviewboard.mozilla.org/r/80970/#review80278
Comment 11•8 years ago
|
||
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30f0eae664b4
enable Linux32 PGO builds. r=dustin
Comment 12•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•