User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0 Build ID: 20160304030206 Steps to reproduce: 1. Start Nightly 2. Open DevTools > Memory 3. Switch view to "Dominators" 4. Select any rows -> Dagre-D3 graph is displayed 5. Switch Label-by to "Call Stack" -> Previous Dagre-D3 graph is still displayed Actual results: Dagre-D3 graph is not updated when switching Label-by Expected results: Is this behavior correct? If this is not, Dagre-D3 graph is updated (clear graph).

> 1. Start Nightly > 2. Open DevTools > Memory > 3. Switch view to "Dominators" + Take snapshot > 4. Select any rows -> Dagre-D3 graph is displayed > 5. Switch Label-by to "Call Stack" -> Previous Dagre-D3 graph is still > displayed

You are correct, it should change the labels for nodes in the graph as we change the "Label By:" option.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=17144c515d06

Comment on attachment 8737996 [details] [diff] [review] Ensure that we maintain the focused node state when changing labels in the dominators view Approval Request Comment [Feature/regressing bug #]: Bug 1229229 [User impact if declined]: The selected node's retaining paths will not be updated when changing label types in memory tool. Also focused node will not persist across changing label types in memory tool. [Describe test coverage new/current, TreeHerder]: Extensive test coverage for memory tool / feature already in m-c. This patch also added a regression test for this particular bug. [Risks and why]: Very little. Devtools only feature. [String/UUID change made/needed]: None.

(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #7) > Comment on attachment 8737996 [details] [diff] [review] > Ensure that we maintain the focused node state when changing labels in the > dominators view > > Approval Request Comment > [Feature/regressing bug #]: > Bug 1229229 Er actually bug 1149385.

Hello magic.cp, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!

Comment on attachment 8737996 [details] [diff] [review] Ensure that we maintain the focused node state when changing labels in the dominators view Regression with new automated test, Aurora47+

(In reply to Ritu Kothari (:ritu) from comment #9) > Hello magic.cp, could you please verify this issue is fixed as expected on a > latest Nightly build? Thanks! My expected result is that graph is cleared when changing labels in the dominators view. This meaning is that node will be lost focus. New behavior is that keeping node focus and updating graph. It's good to me, but this specification does not work if you selected a node in the load more.

Needs rebasing.

Hi Nick, can you please address the concern in comment 11? Thanks!

Based on the verification in comment 11.

(In reply to magicp from comment #11) > (In reply to Ritu Kothari (:ritu) from comment #9) > > Hello magic.cp, could you please verify this issue is fixed as expected on a > > latest Nightly build? Thanks! > > My expected result is that graph is cleared when changing labels in the > dominators view. This meaning is that node will be lost focus. New behavior > is that keeping node focus and updating graph. It's good to me, but this > specification does not work if you selected a node in the load more. Filed bug 1263727 for this.

backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2335247&repo=mozilla-aurora

Backed out for xpcshell failures like https://treeherder.mozilla.org/logviewer.html#?job_id=2350162&repo=mozilla-aurora https://hg.mozilla.org/releases/mozilla-aurora/rev/aa74410e52f0

*sigh* Total brainfart on that one. Would be nice if approval flags could be cleared on patches that got backed out. https://hg.mozilla.org/releases/mozilla-aurora/rev/98da47b4d83c

Comment on attachment 8737996 [details] [diff] [review] Ensure that we maintain the focused node state when changing labels in the dominators view Seems like this never got uplifted to Fx47, clearing out the flags to reflect that.