Closed
Bug 1254795
Opened 9 years ago
Closed 9 years ago
Fix comm-central fallout from bug 1253203
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 affected)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | affected |
People
(Reporter: clokep, Assigned: clokep)
References
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Add some comm-central specific options to old-configure. These are from https://dxr.mozilla.org/comm-central/source/mail/configure.in#33
See conversation at http://logs.glob.uno/?c=mozilla%23build#c8489
01:49 jcranmer is the python configure stuff rejecting any --enable-* that it doesn't recognize?
01:49 glandium jcranmer: yes
01:50 jcranmer glandium: so any suggestions for unbreaking comm-central?
01:50 glandium where does --enable-calendar come from?
01:51 jcranmer https://dxr.mozilla.org/comm-cent...nfig/mozconfigs/linux32/debug#3
01:51 jcranmer unless you mean https://dxr.mozilla.org/comm-central/source/mail/configure.in#33
01:53 glandium jcranmer: for now, add the flags from comm-central to the list in build/moz.configure/old.configure
01:53 jcranmer glandium: so it's an m-c change
01:53 jcranmer ?
01:53 glandium yes
I psuehd a potential fix to https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=95392b427caf&selectedJob=16887
Assignee | ||
Comment 1•9 years ago
|
||
Move the c-c specific configure flags onto the whitelist.
This passes configure for me when on m-c rev 886b5480b578.
Attachment #8728199 -
Flags: review?(mh+mozilla)
Updated•9 years ago
|
Attachment #8728199 -
Flags: review?(mh+mozilla) → review+
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fddd3fdc22a8d82af84ac9b081585d2bea65b04
Bug 1254795 - Add missing --enable flags to old.configure. r=glandium
Assignee | ||
Comment 3•9 years ago
|
||
The port of bug 1253202 were handled in bug 1254922.
Assignee: nobody → clokep
Blocks: 1253203
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Summary: Fix comm-central fallout from bug 1253502 / bug 1253203 → Fix comm-central fallout from bug 1253203
Target Milestone: --- → mozilla48
Comment 4•9 years ago
|
||
bugherder |
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•