Closed Bug 1260089 Opened 9 years ago Closed 9 years ago

[TV][Sync][v2.5] Ignore a deleting operation for a non-existing bookmark record

Categories

(Firefox OS Graveyard :: Sync, defect, P1)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- fixed

People

(Reporter: selee, Assigned: selee)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(2 files)

[gaia] weilonge:seanlee/DataSync/master/Bug1260089 > mozilla-b2g:master
(deleted), text/x-github-pull-request
mbdejong
: review+
jocheng
: approval-gaia-v2.5+
Details
[gaia] weilonge:seanlee/DataSync/v2.5/Bug1260089 > mozilla-b2g:v2.5
(deleted), text/x-github-pull-request
Details
Show a warning message for deleting a non-existing bookmark record and return early.
blocking-b2g: --- → 2.5?
Comment on attachment 8735389 [details] [gaia] weilonge:seanlee/DataSync/master/Bug1260089 > mozilla-b2g:master Hey Michiel, Could you help to review this patch? Thank you!
Attachment #8735389 - Flags: review?(mbdejong)
Comment on attachment 8735389 [details] [gaia] weilonge:seanlee/DataSync/master/Bug1260089 > mozilla-b2g:master r+ (apart from TreeHerder which looks a mess, but I guess that's just business as usual nowadays).
Attachment #8735389 - Flags: review?(mbdejong) → review+
landed on master: https://github.com/mozilla-b2g/gaia/commit/0d0dfc0413e38dd100073c562aa87f84348a8ffe
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 8735389 [details] [gaia] weilonge:seanlee/DataSync/master/Bug1260089 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 1194108 [User impact] if declined: Sync feature will crash when deleting a non-existing record. [Testing completed]: Verified by Partner and test-case. [Risk to taking this patch] (and alternatives if risky): minor [String changes made]: none
Attachment #8735389 - Flags: approval-gaia-v2.5?
blocking-b2g: 2.5? → 2.5+
Whiteboard: [ft:conndevices]
Comment on attachment 8735389 [details] [gaia] weilonge:seanlee/DataSync/master/Bug1260089 > mozilla-b2g:master Approve for TV 2.5
Attachment #8735389 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: