Closed Bug 1260984 Opened 9 years ago Closed 9 years ago

Reduce static data sizes by separating js::ClassSpec from js::Class

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla48
Tracking Flags:
Tracking Status
firefox48 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

(Whiteboard: [MemShrink])

Attachments

(3 files)

(part 1) - Remove ClonedBlockObject::objectOps_
(deleted), patch
jorendorff
: review+
Details | Diff | Splinter Review
(part 2) - Reduce ObjectOps exposure
(deleted), patch
jorendorff
: review+
Details | Diff | Splinter Review
(part 3) - Separate js::ClassSpec from js::Class
(deleted), patch
jorendorff
: review+
Details | Diff | Splinter Review
Bug 1259194 moved ObjectOps out of js::Class, reducing static data by 208 KiB (on 64-bit) in the process. This bug is about doing the same thing with ClassSpec. The reduction is 138 KiB, which a bit smaller because ClassSpec is 8 words compared to ObjectOps' 12 words, but still pretty good.
It's full of nulls which means that JS_NULL_OBJECT_OPS suffices.
Attachment #8736608 - Flags: review?(efaustbmo)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
A number of ObjectOps instances are more exposed than they need to be. This patch converts several to be either private (within a class) or static (within a file).
Attachment #8736609 - Flags: review?(efaustbmo)
js::ObjectOps is often all null. When it's not all null, it's often duplicated among classes. By pulling it out into its own struct, and using a (possibly null) pointer in js::Class, we can save 138 KiB per process on 64-bit, and half that on 32-bit.
Attachment #8736611 - Flags: review?(efaustbmo)
Comment on attachment 8736608 [details] [diff] [review] (part 1) - Remove ClonedBlockObject::objectOps_ Review of attachment 8736608 [details] [diff] [review]: ----------------------------------------------------------------- *steal*
Attachment #8736608 - Flags: review?(efaustbmo) → review+
Attachment #8736609 - Flags: review?(efaustbmo) → review+
Comment on attachment 8736611 [details] [diff] [review] (part 3) - Separate js::ClassSpec from js::Class Review of attachment 8736611 [details] [diff] [review]: ----------------------------------------------------------------- The commit message still refers to js::ObjectOps rather than js::ClassSpec.
Attachment #8736611 - Flags: review?(efaustbmo) → review+
Blocks: 1261720
https://hg.mozilla.org/mozilla-central/rev/fb1734c047af https://hg.mozilla.org/mozilla-central/rev/0ed129db5548 https://hg.mozilla.org/mozilla-central/rev/f29f34e249d2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: