Closed
Bug 1262052
Opened 9 years ago
Closed 8 years ago
Remove -mandroid default parameter from gcc
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox48 affected, firefox50 fixed)
RESOLVED
FIXED
mozilla50
People
(Reporter: m_kato, Unassigned)
References
Details
Attachments
(1 file)
-madnroid parameter required on gcc 4.2 and 4.4 era that Android NDK had. But this option isn't required now since our requirement is gcc 4.8+.
According to gcc document (https://gcc.gnu.org/onlinedocs/gcc/GNU_002fLinux-Options.html),
-mandroid
Compile code compatible with Android platform. This is the default on ‘*-*-linux-*android*’ targets.
So, NDK sets target is *-linux-*android*, so this parameter is default, so it is unnecessary.
And clang doesn't support this option. So to use clang for Android, we have to modify android.m4 to use it.
Comment 1•9 years ago
|
||
I've already did this as part of moving that to moz.configure. The patch is huge and I'm currently splitting it in small pieces for review.
Reporter | ||
Comment 2•8 years ago
|
||
When target is Android, -mandroid is default parameter from gcc 4.6 So we don't need add this options.
Also clang doesn't support this argument.
Review commit: https://reviewboard.mozilla.org/r/57558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57558/
Attachment #8759595 -
Flags: review?(mh+mozilla)
Comment 3•8 years ago
|
||
Comment on attachment 8759595 [details]
Bug 1262052 - Remove unnecessary -mandroid parameter.
https://reviewboard.mozilla.org/r/57558/#review54968
You should do the same in old-configure.in and js/src/old-configure.in.
Attachment #8759595 -
Flags: review?(mh+mozilla) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f5be0d15ff0
Remove unnecessary -mandroid parameter. r=glandium
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•