Closed
Bug 1268242
Opened 9 years ago
Closed 8 years ago
"Verified" button's link in the Autoclassify panel should open into a new tab.
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: KWierso, Assigned: jgraham)
References
Details
Attachments
(1 file)
At the moment, if I click to save an autoclassification, the "Save" button changes to "Verified". If I click that "Verified" button, it opens the current page to https://treeherder.mozilla.org/failureviewer.html#/?classified_failure_id=<ID>
It should open into a new tab so it doesn't take me away from Treeherder.
Flags: needinfo?(james)
|
Reporter | |
Comment 1•9 years ago
|
||
The "Other matching failures..." link already opens a new tab, as it should, so this would just be to get the Verified button to do the same thing.
|
Assignee | |
Comment 2•9 years ago
|
||
Should be easy to fix, just add target=_blank to the relevant link. I can do it, but patches are also accepted ;)
Flags: needinfo?(james)
|
||
Updated•8 years ago
|
Priority: -- → P2
|
||
Comment 3•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8767225 -
Flags: review?(cdawson)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8767225 [details]
[treeherder] mozilla:open_link_new_window > mozilla:master
Easiest. Review. Ever. :)
Attachment #8767225 -
Flags: review?(cdawson) → review+
|
||
Comment 5•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/f530816dbd9d8610bb9e0e1aae431405147e1354
Bug 1268242 - Open all links from autoclassification panel in new window/tab (#1641)
|
||
Updated•8 years ago
|
Assignee: nobody → james
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•