When I tried to migrate my addon "Only Minor Update" to WebExtensions, I realized that there are too few information under "chrome.PlatformInfo". https://addons.mozilla.org/firefox/addon/only-minor-update/ The addon downloads Firefox's update information internally and blocks it if it includes a major update (like Firefox 38 to 45), to allow Firefox to apply only security fixes. The addon tries to complete the URL from "app.update.url" like "https://aus5.mozilla.org/update/3/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml". In XUL-based addons we can use nsIURLFormatter ( http://mxr.mozilla.org/mozilla-central/source/toolkit/components/urlformatter/nsURLFormatter.js ) but currently there is no alternative in WebExtensions. Otherwise, I simply need a new option of Firefox itself to ignore major update and apply only security fixes.

Adding more information to chrome.PlatformInfo seemed ok to most people in the meeting, this also seems like a reasonably good first bug.

It's probably worth noting that WebExtensions don't have the ability to block app updates, regardless of whether they have access to this information.

I was unsure about exactly what fields to include, and about the naming, so I played it safe, and went with what Jetpack exposed from AppInfo service, and with the "app" prefix for the properties (since it's exported through *Platform*Info).

Comment on attachment 8788000 [details] bug 1268399 - add runtime.getBrowserInfo() method with AppInfo data https://reviewboard.mozilla.org/r/76530/#review75164 The code itself looks good here, but I think it would make more sense to add a new runtime.getAppInfo() method rather than putting this into PlatformInfo. That means modifying the api schema for runtime, the actual code should be straightforward.

I thought about that, but remembered that Chrome extension docs are intertwined with mentions of "Chrome web apps" (which use the same manifest and a lot of the same APIs), so a method named getAppInfo() might be even more confusing. I understand "Web Extensions" != "Chrome Extensions", but that's still rather unfortunate.. Perhaps an AppInfo key under PlatformInfo makes it clearer what "app" it is referring to? Or something else?

Comment on attachment 8788000 [details] bug 1268399 - add runtime.getBrowserInfo() method with AppInfo data https://reviewboard.mozilla.org/r/76530/#review75324 Looks good, but it would be nice if the test were more explicit. ::: toolkit/components/extensions/ext-runtime.js:82 (Diff revision 4) > }, > > + getBrowserInfo: function() { > + const {name, vendor, version, appBuildID} = Services.appinfo; > + const info = {name, vendor, version, buildID: appBuildID}; > + return Promise.resolve(Object.freeze(info)); No need to `Object.freeze` this. ::: toolkit/components/extensions/schemas/runtime.json:95 (Diff revision 4) > } > }, > { > + "id": "BrowserInfo", > + "type": "object", > + "restrictions": ["content"], This shouldn't be necessary. ::: toolkit/components/extensions/test/xpcshell/test_ext_runtime_getBrowserInfo.js:5 (Diff revision 4) > +add_task(function* mock() { > + const {updateAppInfo} = Cu.import("resource://testing-common/AppInfo.jsm", {}); > + updateAppInfo(); > +}); We should set these to specific values, and check those actual values in the test. It might be best to move the AppInfo setup in `ExtensionXPCShellUtils.jsm` from `startAddonManager` to its own method, and then just test against those values. ::: toolkit/components/extensions/test/xpcshell/test_ext_runtime_getBrowserInfo.js:10 (Diff revision 4) > +add_task(function* mock() { > + const {updateAppInfo} = Cu.import("resource://testing-common/AppInfo.jsm", {}); > + updateAppInfo(); > +}); > + > +function background() { Please move this to the task. ::: toolkit/components/extensions/test/xpcshell/test_ext_runtime_getBrowserInfo.js:24 (Diff revision 4) > + > + browser.test.notifyPass("runtime.getBrowserInfo"); > + }); > +} > + > +add_task(function* test_contentscript() { The test function name doesn't seem very relevant.

Comment on attachment 8788000 [details] bug 1268399 - add runtime.getBrowserInfo() method with AppInfo data https://reviewboard.mozilla.org/r/76530/#review75522 Looks good. Thanks!

has problems to apply: applying 6a4a3bd26229 patching file toolkit/components/extensions/test/xpcshell/xpcshell.ini Hunk #1 FAILED at 37 1 out of 1 hunks FAILED -- saving rejects to file toolkit/components/extensions/test/xpcshell/xpcshell.ini.rej patch failed to apply abort: fix up the working directory and run hg transplant --continue

Pushed by cbook@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/5dea4ee471a3 add runtime.getBrowserInfo() method with AppInfo data r=kmag

it looks like it got landed after all.

Wontfix for 49, could still take this in 50 if it is necessary. But if it can ride with 51, great.

I don't think this needs to be in 50.

New page for getBrowserInfo: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/getBrowserInfo Does this cover it, :zombie?

Yes, thanks Will.