Closed
Bug 1269041
Opened 9 years ago
Closed 4 years ago
Briefly display toolbar when returning to the browser after the app was hidden
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: mcomella, Unassigned)
References
Details
Attachments
(1 file)
Preferred solution to bug 1245493 but blocked on bug 1245523, which causes the page to twitch when the DynamicToolbar animates off the screen.
See [1] for an example. Back-out the hack fix (not the comment changeset!) from bug 1245493 and land the patch I'll attach to this bug.
[1]: https://youtu.be/Hp2SRwhoxDc
Reporter | ||
Comment 1•9 years ago
|
||
There fixes the issue described in bug 1245493, however, there are graphical
glitches in the page content as the toolbar is either hidden or shown so we
couldn't land it - bug 1245523.
Review commit: https://reviewboard.mozilla.org/r/49851/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49851/
Attachment #8747365 -
Flags: review?(ahunt)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8747365 [details]
MozReview Request: Bug 1269041 - Temporarily display the dynamic toolbar in onStart if it is not shown. r=ahunt,f=kats
This patch was already r+'d by ahunt & kats in the other bug, with one caveat:
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #26)
> Comment on attachment 8735668 [details]
> MozReview Request: Bug 1245493 - Add comments to existing code to clarify
> them. r=margaret
>
> This looks pretty good. My only concern is the scenario where the user puts
> their finger down and starts scrolling during the 3 second timer, such that
> the code to hide the toolbar runs while the user's finger is still down
> and/or the toolbar is partly offscreen. Please make sure the behaviour in
> that case isn't buggy.
Attachment #8747365 -
Flags: review?(ahunt) → review+
Comment 3•4 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Assignee | ||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•