Using feb21 commercial trunk build Found while verifying bug 74781 Message is not reloaded in standalone message window after using the "click here" (to download rest of message) link in a truncated message. Steps to reproduce: 1. POP mail account -- go to Account Settings|Disk Space panel and enable the download size limit option and set a small number, say 2, as the limit value. Confirm OK from account settings. 2. Send the account a message larger than the 2K limit, get the message. 3. Message pane can be open or closed, makes no difference in results... open the message in standalone message window. Truncated message text is displayed in the message body. 4. From the standalone message window, click the link "click here" to download the rest of the message. Download occurs, but full message does not load/refresh in the standalone window. Result: Download rest of truncated POP message from standalone window doesn't load full message into the window.

Nominating, since bug 74781 was a nsbeta1+ rating. Note: Full message is indeed downloaded, but doesn't reload full contents in 3-pane with message pane open either if you've done the "click here" from the standalone. User must reselect in 3-pane to see the full contents and reopen to a new standalone message window. Reload in the original standalone window doesn't help -- loads to blank content.

Further side issue of this: 1. Get a truncated message in the 3-pane window, message pane is open. 2. Open to the standalone window, click the link to download rest of message. Close the standalone window. 3. Return to the 3-pane where the message pane still shows the truncated message, click the link in that message --> duplication of message. In fact if you click too fast/multiple clicks, you will get a duplicate message for each click.

Discussed at 3/4 Mail & News bug mtg with Mktng, Eng., and PjM. Decison was to plus bug as a P2.

taking

the basic problem is that when we run the url to fetch the rest of the message, we don't know what window we're running the url in. When the url finishes, we take a guess, by asking for the topmost window. That routine doesn't return the top most window, but rather, just the first window. We then try to reselect the message in that msg window. I'm not even sure that would work for the standalone window if we happened to call it correctly, though I can try it by closing the three pane after opening the standalone msg window.

that didn't work either, because the js function SelectMessage isn't implemented in the stand-alone msg window. Did this ever work?

I'm not sure... sheela or someone else has had this area in 6.x, but it does work in 4.x

with this patch, it will now work if you don't have the three pane window open. In order for this to always work, we'll need a way to either get the topmost msg window correctly, or to associate the window with the url when it's clicked on.

cool, bug 59229 has the top level msg window fix.

Comment on attachment 74763 [details] [diff] [review] part of fix sr=sspitzer

Comment on attachment 74763 [details] [diff] [review] part of fix r=cavin.

Comment on attachment 74763 [details] [diff] [review] part of fix a=asa (on behalf of drivers) for checkin to the 1.0 trunk

my part is fixed and checked in - if you close the 3 pane window, this will work. Once bug 59229 is fixed, the rest of this will work.

marking fixed - didn't take last time...

OK using mar22 commercial trunk build: win98, mac OS 10.1 Having some trouble with linux... still working on it

Not working on linux. I tried a few different profiles and also had stephend try on linux in today's build. Just does not load whether or not the message pane was open in 3-pane. Sometimes the 3-pane is failing to load on clicking the "click here" link, but not all the time...

Double-checked and used the mar20 build, too. Same thing. Never loads into standalone, works on and off in 3-pane.

Navin can take care of the linux problem when he's back - I don't have linux here. I don't know why it would be broken on linux...

This worksforme on linux as long as 3 pane is closed, as david says. This is 25th trunk debug build.

Discussed in Mail News bug meeting. Decided to minus this bug.

Comment on attachment 74763 [details] [diff] [review] part of fix patch landed, bug still open. resolving patch so it doesn't look like an approved change ready to land.

Please update this bug with an [adt1] - [adt3] impact rating (or take it off the list if it doesn't even rate adt3.) Thanks!

forgot to mark wfm

Marking this bug verified worksforme. Carrying forward the remaining issue for linux in a new bug 135523.