Closed
Bug 1272822
Opened 9 years ago
Closed 9 years ago
Consider reducing AMD blacklisting from 8.62.0.0 to 8.56.15.1
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
(deleted),
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
One of the top reasons for not getting WebGL is the AMD blacklists.
Here's a histogram of blacklisted versions from WebGL failures:
{u'6.1.7600.16385': 3,
u'8.33.0.0': 1,
u'8.420.0.0': 1,
u'8.471.0.0': 1,
u'8.479.0.0': 1,
u'8.522.0.0': 1,
u'8.56.1.15': 3,
u'8.56.1.16': 5,
u'8.593.100.0': 5})
I think we should consider reducing the blacklist to 8.56.1.15.
The current choice is AFAIK arbitrary and comes from bug 792190
Assignee | ||
Updated•9 years ago
|
That sounds reasonable. Anthony, if we were to do this, we'd want to track the overall crash numbers for the drivers that we'd allow in (8.56.1.16 and 8.593.100.0), perhaps some others, and track to see what effect, if any.
Jeff, would you want to start by just enabling WebGL on these drivers, blocking the rest of the features?
Flags: needinfo?(jmuizelaar)
Flags: needinfo?(anthony.s.hughes)
Updated•9 years ago
|
OS: Unspecified → Windows
Assignee | ||
Comment 2•9 years ago
|
||
(In reply to Milan Sreckovic [:milan] from comment #1)
> That sounds reasonable. Anthony, if we were to do this, we'd want to track
> the overall crash numbers for the drivers that we'd allow in (8.56.1.16 and
> 8.593.100.0), perhaps some others, and track to see what effect, if any.
>
> Jeff, would you want to start by just enabling WebGL on these drivers,
> blocking the rest of the features?
I think I would unblock everything, but I don't feel very strongly about that position.
Flags: needinfo?(jmuizelaar)
(In reply to Milan Sreckovic [:milan] from comment #1)
> That sounds reasonable. Anthony, if we were to do this, we'd want to track
> the overall crash numbers for the drivers that we'd allow in (8.56.1.16 and
> 8.593.100.0), perhaps some others, and track to see what effect, if any.
You want to track overall crash volume or volume of specific crashes?
Flags: needinfo?(anthony.s.hughes)
Overall, and what we'd consider "graphics" crashes.
Updated•9 years ago
|
Assignee: nobody → jmuizelaar
Assignee | ||
Comment 5•9 years ago
|
||
It's worth noting that 8.56.1.16 is a version that shipped with Windows so if you installed windows and never enabled updates you'd have this driver.
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> It's worth noting that 8.56.1.16 is a version that shipped with Windows so
> if you installed windows and never enabled updates you'd have this driver.
8.56.1.16 is the Win7 SP1 driver
8.56.1.15 is the Win7 RTM driver
(In reply to Milan Sreckovic [:milan] from comment #4)
> Overall, and what we'd consider "graphics" crashes.
I've added prototype that allows graphing any driver version (all vs graphics):
http://ashughes1.github.io/metrics-graphics-gfx/#driver_lookup
Simply enter the driver version and click 'graph'. With this we should be able to graph *any* driver version upon request, not just the ones above. Hopefully this serves what's needed here.
Let me know.
Assignee | ||
Comment 8•9 years ago
|
||
A reasonable driver to compare to with is probably 8.631.0.0. This is one of the windows update drivers that we currently allow that came out later that year.
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Anthony Hughes (:ashughes) [GFX][QA][Mentor] from comment #7)
>
> I've added prototype that allows graphing any driver version (all vs
> graphics):
> http://ashughes1.github.io/metrics-graphics-gfx/#driver_lookup
Is it possible to have these graphs normalized by # of users on a particular driver?
Flags: needinfo?(anthony.s.hughes)
Comment 10•9 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #9)
> Is it possible to have these graphs normalized by # of users on a particular driver?
Done.
Flags: needinfo?(anthony.s.hughes)
Assignee | ||
Comment 11•9 years ago
|
||
The reduces the blocklisting to the version of the AMD driver that shipped with Windows 7 RTM. I've tested out that driver on hardware in Toronto and everything seems to run fine. I ran the WebGL conformance test suite and it only failed a couple of tests. I expect it will fail the same tests with our currently accepted driver but I will double check.
Attachment #8753483 -
Flags: review?(bas)
Updated•9 years ago
|
Attachment #8753483 -
Flags: review?(bas) → review+
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Windows computers with AMD graphics and driver versions between 8.56.1.15 and 8.62.0.0, previously blocking graphics hardware acceleration, are now allowing it.
[Links (documentation, blog post, etc)]:
relnote-firefox:
--- → ?
Milan - Here I think this would be nice to say, but without linking to the bug or some explanation it is hard to express in a short release note. Maybe some of these perf improvements and other things you are suggesting for relnotes could be explained in a blog post and then we could note and link to it from one general release note.
You need to log in
before you can comment on or make changes to this bug.
Description
•