Video controls usually only have content permission. This test being a chrome test makes it impossible to catch certain kind of regressions. One recent example is bug 1273468. (That regression wouldn't be caught even if this is not a chrome test for some other reason, though.)

There are several things we need to do to catch regressions like bug 1273468: 1. make it a normal mochitest rather than chrome test 2. make it possible to enter fullscreen via either adding allowfullscreen to its outer iframe, or making it a popup 3. remove the fullscreenEnabled check, always assume the existence of fullscreen button

Have some WIP patches...

Review commit: https://reviewboard.mozilla.org/r/54210/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54210/

Review commit: https://reviewboard.mozilla.org/r/54212/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54212/

Review commit: https://reviewboard.mozilla.org/r/54214/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54214/

There was some mistake in patch of bug 694696 which incorrectly added 'skip-if' for some unrelated test. This patch reverts those mistakes in addition to just moving the test back. It also attaches the "fullscreen" tag to the test as it triggers that. Review commit: https://reviewboard.mozilla.org/r/54216/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54216/

Comment on attachment 8754743 [details] MozReview Request: Bug 1274104 part 1 - Allow mochitest main document to request fullscreen. r?jmaher https://reviewboard.mozilla.org/r/54210/#review50926 this looks simple. Please test this with --rebuild 3 with you test on try to run all mochitest to ensure we get good coverage.

Comment on attachment 8754744 [details] MozReview Request: Bug 1274104 part 2 - Use SpecialPowers rather than chrome-only things. r?jaws https://reviewboard.mozilla.org/r/54212/#review50972

Comment on attachment 8754745 [details] MozReview Request: Bug 1274104 part 3 - Always treat fullscreen button is available. r?jaws https://reviewboard.mozilla.org/r/54214/#review50974

Comment on attachment 8754746 [details] MozReview Request: Bug 1274104 part 4 - Move test_videocontrols back to normal mochitest. r?jaws https://reviewboard.mozilla.org/r/54216/#review50976

(In reply to Joel Maher (:jmaher) from comment #7) > Comment on attachment 8754743 [details] > MozReview Request: Bug 1274104 part 1 - Allow mochitest main document to > request fullscreen. r?jmaher > > https://reviewboard.mozilla.org/r/54210/#review50926 > > this looks simple. Please test this with --rebuild 3 with you test on try > to run all mochitest to ensure we get good coverage. https://treeherder.mozilla.org/#/jobs?repo=try&revision=a57cc81f06bf Mostly looks fine. Windows tests... bust a lot due to the new AWS instances. The only things I'm concerned is the cl and gpu bustage on ASAN build, but that doesn't seems to be my fault...

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7c6b58dddc196d9773bb40b9b90074b9cac0bdc Bug 1274104 part 1 - Allow mochitest main document to request fullscreen. r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/17786141f3ac3b18f8094a967aae6684492a7769 Bug 1274104 part 2 - Use SpecialPowers rather than chrome-only things. r=jaws https://hg.mozilla.org/integration/mozilla-inbound/rev/0c2fc088a46d389d9ebddaa2f11acc44792ca67c Bug 1274104 part 3 - Always treat fullscreen button is available. r=jaws https://hg.mozilla.org/integration/mozilla-inbound/rev/6db35dcc68856908a0f25e3072fec2fd0cd0662c Bug 1274104 part 4 - Move test_videocontrols back to normal mochitest. r=jaws

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/589b2826c6c5 - dunno which part of which bug in that push, but some part of it caused frequent failures in e10s mochitest-4 APZ tests like https://treeherder.mozilla.org/logviewer.html#?job_id=28479710&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae650554f5190a8e88c9dc33e0ed4bc3ad050802 Bug 1274104 part 1 - Allow mochitest main document to request fullscreen. r=jmaher https://hg.mozilla.org/integration/mozilla-inbound/rev/9bec2581c2247db61595c00d6b400df3349bc5f5 Bug 1274104 part 2 - Use SpecialPowers rather than chrome-only things. r=jaws https://hg.mozilla.org/integration/mozilla-inbound/rev/834445b4a5f1a16dce6504cd7bb8b6f624f30be6 Bug 1274104 part 3 - Always treat fullscreen button is available. r=jaws https://hg.mozilla.org/integration/mozilla-inbound/rev/4326af8f70cd3bbefb38b3d1b9faab4e4aef3fc1 Bug 1274104 part 4 - Move test_videocontrols back to normal mochitest. r=jaws

(In reply to Phil Ringnalda (:philor) from comment #13) > Backed out in > https://hg.mozilla.org/integration/mozilla-inbound/rev/589b2826c6c5 - dunno > which part of which bug in that push, but some part of it caused frequent > failures in e10s mochitest-4 APZ tests like > https://treeherder.mozilla.org/logviewer.html#?job_id=28479710&repo=mozilla- > inbound That shouldn't be related to this bug. It could be bug 931445 which was landed in the same push. Reland the patches here.

https://hg.mozilla.org/mozilla-central/rev/ae650554f519 https://hg.mozilla.org/mozilla-central/rev/9bec2581c224 https://hg.mozilla.org/mozilla-central/rev/834445b4a5f1 https://hg.mozilla.org/mozilla-central/rev/4326af8f70cd

test_videocontrols started failing when it merged to m-c (and back around to the integration branches). I can't figure out what upset the test, so I'm going to back this out again until this can be sorted out. https://treeherder.mozilla.org/logviewer.html#?job_id=3940115&repo=mozilla-central#L16166 https://hg.mozilla.org/mozilla-central/rev/3b664841d774

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e1aa8af35b8e3fc54a2e041e131852c76f73d0c Bug 1274104 - Remove redundant [test_videocontrols.html] section to unbust moz.build

(In reply to Wes Kocher (:KWierso) from comment #17) > test_videocontrols started failing when it merged to m-c (and back around to > the integration branches). I can't figure out what upset the test, so I'm > going to back this out again until this can be sorted out. > https://treeherder.mozilla.org/logviewer.html#?job_id=3940115&repo=mozilla- > central#L16166 > > https://hg.mozilla.org/mozilla-central/rev/3b664841d774 This is caused from a bad merge. An additional "[test_videocontrols.html]" was added to chrome.ini. Since this test has been switched from a chrome mochitest to a plain mochitest, running it as chrome mochitest would certainly get busted.

https://hg.mozilla.org/integration/fx-team/rev/f210985ee6fbaecb00a049eef5c05276125ab994 Bug 1274104 part 1 - Allow mochitest main document to request fullscreen. r=jmaher https://hg.mozilla.org/integration/fx-team/rev/26581e77ff1b6e2d39f53b8fb41778d353b6315e Bug 1274104 part 2 - Use SpecialPowers rather than chrome-only things. r=jaws https://hg.mozilla.org/integration/fx-team/rev/ad65ef375531be5194596b4feec62ba7bdd02c49 Bug 1274104 part 3 - Always treat fullscreen button is available. r=jaws https://hg.mozilla.org/integration/fx-team/rev/2062a9e37ad9b4ccb4eac3d3e34ab67dd407b4eb Bug 1274104 part 4 - Move test_videocontrols back to normal mochitest. r=jaws

Hi Xidorn, seems we still have conflicts. I was trying to merge mozilla-inbound to mozilla-central and got a conflict. Looks like https://tomcat.pastebin.mozilla.org/8872947 could you take a look ?

Just remove all three lines between <<<<<<< and >>>>>>>.

https://hg.mozilla.org/mozilla-central/rev/f210985ee6fb https://hg.mozilla.org/mozilla-central/rev/26581e77ff1b https://hg.mozilla.org/mozilla-central/rev/ad65ef375531 https://hg.mozilla.org/mozilla-central/rev/2062a9e37ad9

Sorry for the bogus attachment.