Closed Bug 1275452 Opened 9 years ago Closed 9 years ago

support anonymous content styling in stylo

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(4 files)

No description provided.
Attachment #8756170 - Flags: review?(bobbyholley)
Comment on attachment 8756169 [details] [diff] [review] Part 1: Add Servo_RestyleSubtree for eagerly restyling a subtree of a document. Review of attachment 8756169 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/style/ServoStyleSet.h @@ +51,5 @@ > > void BeginUpdate(); > nsresult EndUpdate(); > > + void ForceRestyle(nsINode* aNode); I don't particularly like the use of "Force" here. To me that implies that we're throwing away cached data and restyling everything, which isn't going to be what we do here long-term. So maybe just call this RestyleSubtree?
Attachment #8756169 - Flags: review?(bobbyholley) → review+
Comment on attachment 8756170 [details] [diff] [review] Part 2: Eagerly restyle native anonymous content in stylo. Review of attachment 8756170 [details] [diff] [review]: ----------------------------------------------------------------- I don't know my way around the frame constructor well enough to say with certainty that this is the right place to do it, but seems harmless enough.
Attachment #8756170 - Flags: review?(bobbyholley) → review+
Attachment #8756171 - Flags: review?(bobbyholley) → review+
Comment on attachment 8756172 [details] [diff] [review] Part 4: Remove anonymous content styling hack in ServoStyleSet. Review of attachment 8756172 [details] [diff] [review]: ----------------------------------------------------------------- \o/
Attachment #8756172 - Flags: review?(bobbyholley) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: