Closed
Bug 1277648
Opened 9 years ago
Closed 8 years ago
run debug fennec builds alongside opt in taskcluster
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlund, Assigned: jlund)
References
Details
Attachments
(1 file)
rather than trying to add everything for fennec debug at once, let's break it up and start getting things landed. first up, this bug.
Assignee | ||
Comment 1•9 years ago
|
||
this starts running debug fennec builds along opt on central and try.
note: I added tier 2 and other properties to the opt fennec builds because it
seemed like they were implicitly:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-searchStr=taskcluster&filter-tier=1&filter-tier=2&filter-tier=3&exclusion_profile=false&selectedJob=3999887
Review commit: https://reviewboard.mozilla.org/r/57504/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/57504/
Attachment #8759500 -
Flags: review?(dustin)
Updated•9 years ago
|
Assignee: nobody → jlund
Comment 2•9 years ago
|
||
https://reviewboard.mozilla.org/r/57504/#review54264
::: testing/taskcluster/tasks/branches/mozilla-central/job_flags.yml:21
(Diff revision 1)
> - Android
> types:
> opt:
> task: tasks/builds/android_api_15.yml
> + debug:
> + task: tasks/builds/android_api_15_debug.yml
Why is this not just in base_job_flags.yml?
::: testing/taskcluster/tasks/builds/android_api_15_debug.yml:5
(Diff revision 1)
> $inherits:
> from: 'tasks/builds/mobile_base.yml'
> variables:
> build_name: 'android'
> - build_type: 'opt'
> + build_type: 'dbg'
I believe "dbg" just got changed to "debug" for all of the other task types.
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8759500 [details]
Bug 1277648 - run debug fennec builds alongside opt in taskcluster,
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/57504/diff/1-2/
Assignee | ||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/57504/#review54264
> Why is this not just in base_job_flags.yml?
do you mean base_jobs.yml? I was keeping where we build android debug to the same place as opt for the moment while I iterate. once things look good, I was going to move debug _and_ the current opt builds to base_jobs.yml and add the flag under `all` for base_jobs_flags.yml.
> I believe "dbg" just got changed to "debug" for all of the other task types.
I guess I based it off linux/osx: https://dxr.mozilla.org/mozilla-central/search?q=path%3Ataskcluster%2Ftasks%2Fbuild+dbg+build_type&redirect=true
but I should have been looking at: https://dxr.mozilla.org/mozilla-central/search?q=path%3Ataskcluster%2Ftasks%2Fbuild+debug+build_type&redirect=true
Assignee | ||
Comment 5•9 years ago
|
||
(In reply to Jordan Lund (:jlund) from comment #3)
> Comment on attachment 8759500 [details]
> Bug 1277648 - run debug fennec builds alongside opt in taskcluster,
>
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/57504/diff/1-2/
heh, I think my histedit and rebase confused mozreview.. I really need to figure this out. anyway, I believe the only change should be: build_type: 'debug'
Comment 6•9 years ago
|
||
Comment on attachment 8759500 [details]
Bug 1277648 - run debug fennec builds alongside opt in taskcluster,
https://reviewboard.mozilla.org/r/57504/#review54460
Attachment #8759500 -
Flags: review?(dustin) → review+
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e057b5daf5814d41680d6309a7bcca9545380051
Bug 1277648 - run debug fennec builds alongside opt in taskcluster, r=dustin
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16dfedac79db
Followup bustage fix for Bug 1277648
Comment 9•8 years ago
|
||
(In reply to Jordan Lund (:jlund) from comment #7)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> e057b5daf5814d41680d6309a7bcca9545380051
> Bug 1277648 - run debug fennec builds alongside opt in taskcluster, r=dustin
I took the liberty of landing a followup fix to unbust m-c by next merge and try.
(a failing job was: https://tools.taskcluster.net/task-inspector/#cazEvlUESEyG8gX-j_BUAg/0 )
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e057b5daf581
https://hg.mozilla.org/mozilla-central/rev/16dfedac79db
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 1284874
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•