Closed
Bug 127784
Opened 23 years ago
Closed 23 years ago
Require restart on theme switch
Categories
(SeaMonkey :: Themes, defect, P1)
SeaMonkey
Themes
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0
People
(Reporter: buckland, Assigned: bugzilla)
References
Details
(Whiteboard: [adt1])
Attachments
(1 file)
(deleted),
patch
|
hewitt
:
review+
bugs
:
superreview+
dbaron
:
approval+
|
Details | Diff | Splinter Review |
Discussed in 2/25/2002 ADT mtng. Decision was to require restart on theme
switch. See also Bugzilla 124009 and 124205
Reporter | ||
Updated•23 years ago
|
Comment 2•23 years ago
|
||
Changing component to preferences and reassigning.
Assignee: attinasi → sgehani
Component: Layout → Preferences
QA Contact: moied → sairuh
Comment 6•23 years ago
|
||
Removing *crash* keyword, as this bug is not specifically about a crash, but a
request to require Theme Switching to require a restart.
Keywords: crash
Comment 7•23 years ago
|
||
*** Bug 128168 has been marked as a duplicate of this bug. ***
Comment 8•23 years ago
|
||
nsbeta1+ per Nav triage team
Assignee | ||
Comment 10•23 years ago
|
||
since I was given bug 128168, I'll take this one...
Assignee: hewitt → blaker
Status: ASSIGNED → NEW
Comment 11•23 years ago
|
||
How about adding an option in debug prefs?
[ ] Enable dynamic theme switching (no required restart)
Off by default.
That way, hewitt will continue to have fun with it.
Comment 12•23 years ago
|
||
> [ ] Enable dynamic theme switching (no required restart)
Ack! This is the coolest feature in 0.9.8. :-)
Assignee | ||
Comment 13•23 years ago
|
||
Comment 14•23 years ago
|
||
Comment on attachment 73479 [details] [diff] [review]
patch
I'd insist on a pref if this worked most of the time on the trunk... but it
almost always crashes on me (or crashes shortly after switching).
Also, blake assures me the drag handler stuff is part of a separate bug, so my
sr=ben@netscape.com applies to all other parts of the patch.
Attachment #73479 -
Flags: superreview+
Comment 15•23 years ago
|
||
After 1.0 we should dedicate an entire milestone to making dynamic skin
switching work perfectly. It's getting a little tedious the way we disable it
before any major release.
No longer blocks: 123715
Comment 16•23 years ago
|
||
Not a chance. What's tedious is that we keep enabling it and having critical
regressions. What we should really do is dump skin switching entirely, it isn't
worth the cost.
Comment 17•23 years ago
|
||
blake, can you get an r= on this? let me know if not, i can help you.
Comment 18•23 years ago
|
||
Comment on attachment 73479 [details] [diff] [review]
patch
r=me
Attachment #73479 -
Flags: review+
Comment 19•23 years ago
|
||
Comment on attachment 73479 [details] [diff] [review]
patch
a=dbaron for trunk checkin.
I would like to note (in response to comment 16) that many of the crashes right
now are probably due to a single problem, the one described in bug 121055. The
new implementation of theme switching (since it was turned back on) should be a
good bit safer than the old one. It's just there were some details wrong...
Attachment #73479 -
Flags: approval+
Assignee | ||
Comment 21•23 years ago
|
||
fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 22•23 years ago
|
||
Another very cool feature dying entirely?
Comment 23•23 years ago
|
||
What happens if you have a couple of different profiles you are accessing
through the quickload feature and each profile uses a different skin? Will
having to restart the app impact the ability to switch between profiles with
Mozilla staying in memory?
That would be a drag.
Comment 24•23 years ago
|
||
Verified on all platforms (commecial netscape build: 2002-03-25-08-TRUNK). While
switching themes, a dialog should pop up like this
"Theme changes will take effect when you restart Netscape 6".
Status: RESOLVED → VERIFIED
Comment 25•22 years ago
|
||
Okay, I just read through what I think are all applicable bugs, so hopefully
I'll sound less ignorant that I really am... I miss dynamic theme switching! It
is a great feature, and, incidentally, one that I never had any problems with
(that I know about, anyway). Having to restart the browser every time I change
my theme, which is something that happens fairly often, is getting to be a royal
pain in the butt. Thanks to tabs, I now have not just one web page open that I
need to bookmark and come back to, but potentially *many*. The "Bookmark this
group of tabs" feature goes a long way toward alleviating some of this
annoyance, but not far enough.
Basically, what I'm saying is - bring back dynamic theme switching! If there are
problems with it, fix 'em! I know that there's lots of other things on mozilla
org's to-do list, I'm just asking that this be one of them. Okay, thanks!
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•