Closed Bug 127784 Opened 23 years ago Closed 23 years ago

Require restart on theme switch

Categories

(SeaMonkey :: Themes, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0

People

(Reporter: buckland, Assigned: bugzilla)

References

Details

(Whiteboard: [adt1])

Attachments

(1 file)

Discussed in 2/25/2002 ADT mtng. Decision was to require restart on theme switch. See also Bugzilla 124009 and 124205
Keywords: crash, nsbeta1
Changing QA contact
QA Contact: petersen → moied
Changing component to preferences and reassigning.
Assignee: attinasi → sgehani
Component: Layout → Preferences
QA Contact: moied → sairuh
-> Themes per pref ownership model
Component: Preferences → Themes
Patty should probably qa this change.
QA Contact: sairuh → pmac
Meant to reassign to Themes owner.
Assignee: sgehani → hewitt
Removing *crash* keyword, as this bug is not specifically about a crash, but a request to require Theme Switching to require a restart.
Keywords: crash
Blocks: 121638
Blocks: 116038
*** Bug 128168 has been marked as a duplicate of this bug. ***
Blocks: 121963
Blocks: 122111
Blocks: 123715
nsbeta1+ per Nav triage team
Keywords: nsbeta1nsbeta1+
Target Milestone: --- → mozilla1.0
Blocks: 127716
BOOHOO!! :( ah well, it was fun while it lasted
Status: NEW → ASSIGNED
since I was given bug 128168, I'll take this one...
Assignee: hewitt → blaker
Status: ASSIGNED → NEW
How about adding an option in debug prefs? [ ] Enable dynamic theme switching (no required restart) Off by default. That way, hewitt will continue to have fun with it.
> [ ] Enable dynamic theme switching (no required restart) Ack! This is the coolest feature in 0.9.8. :-)
Attached patch patch (deleted) — Splinter Review
Comment on attachment 73479 [details] [diff] [review] patch I'd insist on a pref if this worked most of the time on the trunk... but it almost always crashes on me (or crashes shortly after switching). Also, blake assures me the drag handler stuff is part of a separate bug, so my sr=ben@netscape.com applies to all other parts of the patch.
Attachment #73479 - Flags: superreview+
Blocks: 124009
Blocks: 124205
Blocks: 125518
After 1.0 we should dedicate an entire milestone to making dynamic skin switching work perfectly. It's getting a little tedious the way we disable it before any major release.
No longer blocks: 123715
Not a chance. What's tedious is that we keep enabling it and having critical regressions. What we should really do is dump skin switching entirely, it isn't worth the cost.
blake, can you get an r= on this? let me know if not, i can help you.
Whiteboard: [adt1]
Blocks: 124421
No longer blocks: 124421
Blocks: 121055
Blocks: 130756
Attachment #73479 - Flags: review+
Comment on attachment 73479 [details] [diff] [review] patch a=dbaron for trunk checkin. I would like to note (in response to comment 16) that many of the crashes right now are probably due to a single problem, the one described in bug 121055. The new implementation of theme switching (since it was turned back on) should be a good bit safer than the old one. It's just there were some details wrong...
Attachment #73479 - Flags: approval+
Blake, would you like someone else to take this?
Priority: -- → P1
Blocks: 79821
fixed.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Another very cool feature dying entirely?
What happens if you have a couple of different profiles you are accessing through the quickload feature and each profile uses a different skin? Will having to restart the app impact the ability to switch between profiles with Mozilla staying in memory? That would be a drag.
Verified on all platforms (commecial netscape build: 2002-03-25-08-TRUNK). While switching themes, a dialog should pop up like this "Theme changes will take effect when you restart Netscape 6".
Status: RESOLVED → VERIFIED
Blocks: 124421
No longer blocks: 124421
Blocks: 124421
Okay, I just read through what I think are all applicable bugs, so hopefully I'll sound less ignorant that I really am... I miss dynamic theme switching! It is a great feature, and, incidentally, one that I never had any problems with (that I know about, anyway). Having to restart the browser every time I change my theme, which is something that happens fairly often, is getting to be a royal pain in the butt. Thanks to tabs, I now have not just one web page open that I need to bookmark and come back to, but potentially *many*. The "Bookmark this group of tabs" feature goes a long way toward alleviating some of this annoyance, but not far enough. Basically, what I'm saying is - bring back dynamic theme switching! If there are problems with it, fix 'em! I know that there's lots of other things on mozilla org's to-do list, I'm just asking that this be one of them. Okay, thanks!
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: