Open Bug 1280893 Opened 8 years ago Updated 3 years ago

[tracking] Implement checks for Fluent messages

Categories

(Localization Infrastructure and Tools :: compare-locales, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

People

(Reporter: Pike, Unassigned)

References

(Depends on 3 open bugs)

Details

(Whiteboard: [gecko-l20n])

User Story

Implement checks for:

[x] Values

[x] Attributes
  [x] missing and obsolete
  [x] duplicates

[ ] Interpolations
  [ ] external arguments
  [ ] built-ins
  [ ] message references
  [ ] selectors

[ ] Sections
On top of the mere file-format support for l20n from bug 1280891, we also need some l20n-specific checks. This might turn into a tracker of the individual checks. For now, we block bug gecko-l10n, but that might be something to just do for individual bugs. stas, one question I already have is if we know anything yet about en-US-specific traits?
Flags: needinfo?(stas)
Mass change dependency tree for bug 1279002 into a whiteboard keyword.
No longer blocks: gecko-l20n
Whiteboard: [gecko-l20n]
Blocks: 1291693
I tagged comment 1 and comment 3 as obsolete as they referred to the old syntax of L20n which used to have "traits". Fluent has attributes instead which are always part of the public interface of the message they're defined on. Attribute should always be checked by compare-locales.
Bug 1199670 added the following checks: - missing and obsolete values (error) - missing and obsolete attributes (error) - duplicate attributes (warning) Let's use this bug as a tracker for adding more checks. Please file new bugs blocking this one when working on new checks.
Summary: Implement checks for l20n in ftl values → [tracking] Implement checks for Fluent messages
User Story: (updated)
Hooking up some existing bugs we filed as follow-ups. Re Section tests, we could for example warn if the sections of the original file don't exist if there are entities from those sections present in the localizations. Also, duplicate sections? Not sure how bad that'd be.
Depends on: 1376746, 1376747
Thanks for linking the other bugs. Sections in Fluent are really just glorified comments. As such I don't think it should be forbidden to have duplicate sections. In fact it might even be useful for grouping things like buttons, actions, shortcuts etc.
Depends on: 1385863
Depends on: 1525514
Depends on: 1528627
Depends on: 1529589
Depends on: 1454249
Depends on: 1533410
Depends on: 1535611
Type: defect → enhancement
Depends on: 1584912
No longer blocks: 1291693
You need to log in before you can comment on or make changes to this bug.