Closed
Bug 1285400
Opened 8 years ago
Closed 7 years ago
[encoding] Support for GBK encoding
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla56
People
(Reporter: addison, Assigned: hsivonen)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fixed by encoding_rs])
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160604131506
Steps to reproduce:
The W3C I18N WG in cooperation with WhatWG has created tests for the Encoding specification. In testing the encoding:
GBK
Our tests found 254 total character mapping errors. In addition 3 of the 5 decoder tests failed. Note that bug 1285393 blocks a number of tests.
Actual results:
Please see:
https://github.com/whatwg/encoding/issues/56
Expected results:
Please reply on the above github issue in addition to addressing this bug here. If there are errors in our tests or in the specification, we would very much like to know!
[filed for W3C I18N WG]
Comment 1•8 years ago
|
||
Henri may have thoughts here given his related work.
Assignee | ||
Comment 2•8 years ago
|
||
Per bug 1261841, I'm working on rewriting our encoding converters in Rust. I'm at the rather inconvenient point where things are so far along (implementations for all encodings written) that it doesn't make sense to put effort into fixing anything other than critical security vulnerabilities in the old ones but also the new implementations aren't testable in a browser yet.
The new GBK implementation is at https://github.com/hsivonen/encoding_rs/blob/master/src/gb18030.rs
It can be tested outside a browser using a sample app whose source is available from https://github.com/hsivonen/recode_rs
Depends on: encoding_rs
Updated•8 years ago
|
Priority: -- → P3
Comment 3•7 years ago
|
||
One encoder test still fails, and apparently the decoder has no improvement.
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #3)
> One encoder test still fails, and apparently the decoder has no improvement.
As commented previously on GitHub (https://github.com/whatwg/encoding/issues/56#issuecomment-297746473), I believe the remaining failures are test suite bugs.
Fixed by bug 1261841.
Assignee: nobody → hsivonen
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by encoding_rs]
Assignee | ||
Updated•7 years ago
|
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•