mozbuild fails to include linux/ files from audio_device.gypi which leads to the following error. As filename_rules.gypi started to carry BSD bits before bug 807492 landed I've completely missed the issue. media/webrtc/trunk/webrtc/modules/modules_video_capture_module/Unified_cpp_webrtc_modules0.o: In function `webrtc::VideoCaptureFactory::Create(int, char const*)': Unified_cpp_webrtc_modules0.cpp:(.text._ZN6webrtc19VideoCaptureFactory6CreateEiPKc+0x5): undefined reference to `webrtc::videocapturemodule::VideoCaptureImpl::Create(int, char const*)' media/webrtc/trunk/webrtc/modules/modules_video_capture_module/Unified_cpp_webrtc_modules0.o: In function `webrtc::VideoCaptureFactory::CreateDeviceInfo(int)': Unified_cpp_webrtc_modules0.cpp:(.text._ZN6webrtc19VideoCaptureFactory16CreateDeviceInfoEi+0x5): undefined reference to `webrtc::videocapturemodule::VideoCaptureImpl::CreateDeviceInfo(int)' media/webrtc/trunk/webrtc/modules/modules_audio_device/Unified_cpp_webrtc_modules0.o: In function `webrtc::AudioDeviceModuleImpl::CreatePlatformSpecificObjects()': Unified_cpp_webrtc_modules0.cpp:(.text._ZN6webrtc21AudioDeviceModuleImpl29CreatePlatformSpecificObjectsEv+0x5f): undefined reference to `webrtc::AudioDeviceLinuxALSA::AudioDeviceLinuxALSA(int)' Unified_cpp_webrtc_modules0.cpp:(.text._ZN6webrtc21AudioDeviceModuleImpl29CreatePlatformSpecificObjectsEv+0xb2): undefined reference to `webrtc::AudioDeviceUtilityLinux::AudioDeviceUtilityLinux(int)' Unified_cpp_webrtc_modules0.cpp:(.text._ZN6webrtc21AudioDeviceModuleImpl29CreatePlatformSpecificObjectsEv+0xe3): undefined reference to `webrtc::AudioDeviceLinuxALSA::AudioDeviceLinuxALSA(int)' Unified_cpp_webrtc_modules0.cpp:(.text._ZN6webrtc21AudioDeviceModuleImpl29CreatePlatformSpecificObjectsEv+0x1f2): undefined reference to `webrtc::AudioDeviceUtilityLinux::AudioDeviceUtilityLinux(int)' /usr/bin/ld: libxul.so: hidden symbol `_ZN6webrtc20AudioDeviceLinuxALSAC1Ei' isn't defined /usr/bin/ld: final link failed: Bad value

Review commit: https://reviewboard.mozilla.org/r/63070/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63070/

Comment on attachment 8769101 [details] Bug 1285501 - Build linux/ directory on DragonFly, NetBSD and Solaris as well. https://reviewboard.mozilla.org/r/63070/#review61468

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f5df71ccaebb Build linux/ directory on DragonFly, NetBSD and Solaris as well. r=jesup

Comment on attachment 8769101 [details] Bug 1285501 - Build linux/ directory on DragonFly, NetBSD and Solaris as well. Approval Request Comment [ESR consideration]: help Tier3 downstream (DPorts, PkgSrc) drop --disable-webrtc, a NPOTB option [Feature/regressing bug #]: bug 797671 regression [User impact if declined]: Build broken on DragonFly and NetBSD unless --disable-webrtc is added to .mozconfig [Describe test coverage new/current, TreeHerder]: landed on m-c [Risks and why]: Low, can only break build. [String/UUID change made/needed]: None

Comment on attachment 8769101 [details] Bug 1285501 - Build linux/ directory on DragonFly, NetBSD and Solaris as well. Should have no impact on our tier-1 builds, taking it. Should be in 48 beta 8 or 9