Closed
Bug 1286337
Opened 8 years ago
Closed 8 years ago
test_value_storage.html fail with MASK_AS_SHORTHAND turning on
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: u459114, Assigned: u459114)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d1bc67f7660&selectedJob=23729841
INFO TEST-UNEXPECTED-FAIL | layout/style/test/test_value_storage.html | parse+serialize should be idempotent for 'mask: url(404.png) alpha padding-box border-box' - got "url(\"404.png\") repeat 0% 0% border-box add alpha", expected "url(\"404.png\") repeat 0% 0% add alpha"
This is because default value of mask-origin changes from padding to border.
Review commit: https://reviewboard.mozilla.org/r/63754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63754/
Updated•8 years ago
|
Target Milestone: --- → mozilla50
Review commit: https://reviewboard.mozilla.org/r/63834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63834/
Attachment #8770255 -
Attachment description: Bug 1286337 - Correct default value of mask-origin. → Bug 1286337 - Part 1. Correct default value of mask-origin.
Comment on attachment 8770255 [details]
Bug 1286337 - Part 1. Correct default value of mask-origin.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63754/diff/1-2/
Attachment #8770255 -
Flags: review?(cam)
Attachment #8770363 -
Flags: review?(cam)
Hi heycam,
This is a side effect of bug 1258286, we need correct default value judgment in Decalration.cpp as well.
Comment 7•8 years ago
|
||
Comment on attachment 8770255 [details]
Bug 1286337 - Part 1. Correct default value of mask-origin.
https://reviewboard.mozilla.org/r/63754/#review60946
Looks good, thanks.
Attachment #8770255 -
Flags: review?(cam) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8770363 [details]
Bug 1286337 - Part 2. Update initial_values of background and mask in property_database.js
https://reviewboard.mozilla.org/r/63834/#review60948
Attachment #8770363 -
Flags: review?(cam) → review+
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a8a8898431d
Part 1. Correct default value of mask-origin. r=heycam
https://hg.mozilla.org/integration/autoland/rev/b682d06315f8
Part 2. Update initial_values of background and mask in property_database.js r=heycam
Comment 10•8 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•