Closed
Bug 1288472
Opened 8 years ago
Closed 8 years ago
Messed up "Find my Phone" layout on google.com
Categories
(Web Compatibility :: Desktop, defect)
Tracking
(platform-rel +)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
platform-rel | --- | + |
People
(Reporter: miketaylr, Assigned: karlcow)
References
()
Details
(Whiteboard: [country-all] [sitewait] [css][platform-rel-Google])
Attachments
(1 file)
(deleted),
image/png
|
Details |
(This might be a tech evangelism issue, but starting here)
Note: toggling about:config?filter=layout.css.prefixes.webkit makes no difference.
STR: (this assumes you have an Android phone associated with a Google account)
1) Go to https://www.google.com/search?q=find+my+phone+android&ie=utf-8&oe=utf-8
Expected:
Layout looks like it does in Chrome
Actual:
Layout is wonky
Reporter | ||
Comment 1•8 years ago
|
||
Oh. There's a style:
.act-fmp-buttons {
display: flex;
display: -moz-box;
display: -moz-flex;
display: -moz-flexbox;
line-height: 1.4;
padding: 24px;
text-align: center;
}
If I disable the -moz-box rule (allowing `display: flex` to do its thing), the layout looks just like Chrome.
Reporter | ||
Comment 2•8 years ago
|
||
Karl, can we ask Google to fix the order of prefixes (so unprefixed comes last)?
Component: Layout → Desktop
Flags: needinfo?(kdubost)
Product: Core → Tech Evangelism
Whiteboard: [country-all][contactready][css]
Version: 48 Branch → Firefox 48
Comment 3•8 years ago
|
||
Really/better, they should just drop the prefixed "display" keywords here altogether. They do not help, and (in this case) they actively break the page.
In particular:
* "display:-moz-box" is a XUL thing that they almost certainly haven't tested & do not want. (That's what's active in the screenshot that Mike attached here.)
* "display:-moz-flex" has been unnecessary (and unrecognized) effect ever since we unprefixed in bug 801098 (Firefox 19, 4 years ago) So, that's been unrecognized cruft for 4 years now.
* "display: -moz-flexbox" *has always* been unrecognized cruft -- we never shipped a build that recognized that as valid CSS. (They're likely sending that style because "display:flexbox" was a very early spelling in the spec, and it's what IE shipped [prefixed] -- but the spec changed to "display:flex" before we landed our modern-flexbox-implementation, in bug 666041. So, we never shipped any code that recognized "-moz-flexbox".)
So: it'd be best to just ask that they drop all of the fallback CSS in that rule.
Comment 4•8 years ago
|
||
Yeah, I think we should drop XUL-only values for web content.
Comment 5•8 years ago
|
||
Oh, you said "they"... I think those should be dropped in our side as well. Is it expected to cause any compatibility issue to drop the XUL display values?
Assignee | ||
Comment 6•8 years ago
|
||
Xidorn,
`XUL display` values should be safe I guess. I insist on display.
I guess it's partly confusing because in the case of flexbox some examples use these properties
Such as https://developer.mozilla.org/en-US/docs/Web/CSS/box-flex
but there are not really documented https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-box
For others, such as appearance, it is currently used on Web pages (that said not all of them).
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance
Flags: needinfo?(kdubost)
Assignee | ||
Comment 7•8 years ago
|
||
Contacted Google today.
Assignee: nobody → kdubost
Whiteboard: [country-all][contactready][css] → [country-all] [sitewait] [css]
Updated•8 years ago
|
Updated•8 years ago
|
platform-rel: --- → ?
Whiteboard: [country-all] [sitewait] [css] → [country-all] [sitewait] [css][platform-rel-Google]
Updated•8 years ago
|
platform-rel: ? → +
Reporter | ||
Comment 8•8 years ago
|
||
This has been fixed, thanks Google!
Reporter | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Tech Evangelism → Web Compatibility
You need to log in
before you can comment on or make changes to this bug.
Description
•