Closed
Bug 1289294
Opened 8 years ago
Closed 8 years ago
Move MT detection to python configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox50 fixed)
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67100/
Attachment #8774639 -
Flags: review?(cmanchester)
Updated•8 years ago
|
Attachment #8774639 -
Flags: review?(cmanchester) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8774639 [details]
Bug 1289294 - Move MT detection to python configure.
https://reviewboard.mozilla.org/r/67100/#review64326
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8774639 [details]
Bug 1289294 - Move MT detection to python configure.
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67100/diff/1-2/
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/a9896c4309bb
Move MT detection to python configure. r=chmanchester
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Comment 6•8 years ago
|
||
This seems to have broken my build on Windows 10 (Insider build), where the mt.exe I have does not report any version number. Previously, it looks like failure to read the MT version would issue a warning, but continue; now, it's a fatal configure-time error. :(
Assignee | ||
Comment 7•8 years ago
|
||
Where is your MT, and what does running it without arguments print out?
Comment 8•8 years ago
|
||
$ which mt
/c/Program Files (x86)/Windows Kits/10/bin/x64/mt.exe
$ mt
Microsoft (R) Manifest Tool
Copyright (c) Microsoft Corporation.
All rights reserved.
Usage:
-----
mt.exe
[ -manifest <manifest1 name> <manifest2 name> ... ]
[ -identity:<identity string> ]
[ < <[-rgs:<.rgs filename>] [-tlb:<.tlb filename>]> -dll:<filename> > [ -replacements:<XML filename> ] ]
[ -managedassemblyname:<managed assembly> [ -nodependency ] ]
[ -out:<output manifest name> ]
[ -inputresource:<file>[;[#]<resource_id>] ]
[ -outputresource:<file>[;[#]<resource_id>] ]
[ -updateresource:<file>[;[#]<resource_id>] ]
[ -hashupdate[:<path to the files>] ]
[ -makecdfs ]
[ -validate_manifest ]
[ -validate_file_hashes:<path to the files> ]
[ -canonicalize ]
[ -check_for_duplicates ]
[ -nologo ]
...followed by extensive help about the options.
Assignee | ||
Comment 9•8 years ago
|
||
O_o this doesn't match what mt's output looks like on my sdk 10... wtf? Please file a followup bug, with, additionally, the list of directories under /c/Program Files (x86)/Windows Kits/10/Include.
Comment 10•8 years ago
|
||
I hit same issue. I use insider version of Windows SDK 10 (10.0.14383.0) from https://developer.microsoft.com/en-us/windows/downloads/windows-10-developer-preview.
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•