Closed
Bug 1294207
Opened 8 years ago
Closed 8 years ago
SkFontHost_cairo does not check if FT_LIbrary_SetLcdFilter actually works
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: lsalzman, Assigned: lsalzman)
References
Details
(Keywords: regression, Whiteboard: [gfx-noted])
Attachments
(1 file)
(deleted),
patch
|
gw280
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
FT_Library_SetLcdFilter may be provided by FreeType even though it is built without FT_CONFIG_OPTION_SUBPIXEL_RENDERING defined. When this happens, it messes up SkFontHost_cairo's glyph size calculations, and causes the following assertion to trigger:
gfx/skia/skia/src/ports/SkFontHost_FreeType_common.cpp:116: fatal error: 3 * mask.fBounds.width() == static_cast<int>(bitmap.width)
This prevents any text from rendering properly.
This problem was introduced by SkFontHost_cairo rewrites in bug 1287552.
Attachment #8779837 -
Flags: review?(gwright)
Assignee | ||
Updated•8 years ago
|
Blocks: skia-linux
Whiteboard: [gfx-noted]
Updated•8 years ago
|
Attachment #8779837 -
Flags: review?(gwright) → review+
Comment 1•8 years ago
|
||
So we need this on Aurora too, right?
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #1)
> So we need this on Aurora too, right?
Yes, 50+.
Version: unspecified → 50 Branch
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fc85f62601e
detect if FreeType supports lcd filtering in SkFontHost_cairo. r=gw280
Comment 4•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8779837 [details] [diff] [review]
detect if FreeType supports lcd filtering in SkFontHost_cairo
Approval Request Comment
[Feature/regressing bug #]: bug 1287552, so 50+
[User impact if declined]: Regression causing garbled fonts when using subpixel AA on Linux.
[Describe test coverage new/current, TreeHerder]: mochitests/reftests
[Risks and why]: Basically none. The patch disables use of a feature when it is detected as not available, whereas before it would always assume it was available (which cause the regression).
[String/UUID change made/needed]: None
Attachment #8779837 -
Flags: approval-mozilla-aurora?
status-firefox50:
--- → affected
Keywords: regression
Comment on attachment 8779837 [details] [diff] [review]
detect if FreeType supports lcd filtering in SkFontHost_cairo
Fixes a recent regression, linux only, Aurora50+
Attachment #8779837 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•8 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•