Closed Bug 1301122 Opened 8 years ago Closed 8 years ago

Update the rules for building SM-tc(pkg) to cover more cases

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: RyanVM, Assigned: sfink)

References

Details

Attachments

(1 file)

Over in bug 1289194, a landing outside js/src managed to break SM-tc(pkg) jobs. Said bustage showed up on later pushes that touched js/src. It's also easy to see how this could have been caught by a Try push had the job run there. Maybe adding just the top-level moz.build to the rules would suffice here?
It pulls from a number of different areas. We should add /configure.py /moz.configure /test.mozbuild /intl/icu/... /Makefile.in /moz.build /nsprpub/... /build/... /config/... /mfbt/... /python/... and then some weird stuff: /dom/bindings/mozwebidlcodegen /media/webrtc/trunk/tools/gyp /testing/mozbase/... /modules/fdlibm/... /modules/zlib/... /layout/tools/reftest/... /toolkit/mozapps/installer/... /mozglue/... /memory/... though it might be nice if we could remove the dependency on some of that stuff.
Actually, almost everything in there is already in the list. The only exceptions I see are: Makefile.in moz.build config/** I'll wait for bug 1286075 to land, unless dustin adds it in himself.
Depends on: 1286075
Perhaps config/** is overkill, but I'm just blindly adding everything mentioned in make-source-package.sh.
Attachment #8791408 - Flags: review?(nfitzgerald)
Assignee: nobody → sphink
Status: NEW → ASSIGNED
Comment on attachment 8791408 [details] [diff] [review] Add in more files to trigger the sm-package job Review of attachment 8791408 [details] [diff] [review]: ----------------------------------------------------------------- Unlike with GCs, a conservative approach seems like a good one in this case.
Attachment #8791408 - Flags: review?(nfitzgerald) → review+
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/edf9ffaf92b0 Add in more files to trigger the sm-package job, r=fitzgen
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: