Closed
Bug 1306276
Opened 8 years ago
Closed 8 years ago
Deprecate History RemovePage and RemovePages
Categories
(Toolkit :: Places, defect, P2)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
(Keywords: addon-compat)
Attachments
(1 file)
We have replacements in History.jsm::remove.
The scope here is to add a @deprecated javadoc in nsIBrowserHistory.idl with a comment like "Please use PlacesUtils.history.remove instead." and to add PLACES_WARN_DEPRECATED(); in the implementation in nsNavHistory.cpp
This is not actually breaking add-ons yet, but it will when we'll remove the methods in future.
|
Assignee | |
Comment 1•8 years ago
|
||
We can make the patch now, but before landing it we need to fix Bug 1087255 and, if possible, bug 1086549, to avoid spamming the console on debug builds.
There are previous patches in both bugs that need unbitrotting and likely test fixes.
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → mak77
Whiteboard: [good first bug] → [good first bug][lang
|
|
Assignee | |
Updated•8 years ago
|
Mentor: mak77
Whiteboard: [good first bug][lang
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8849969 -
Flags: review?(standard8)
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8849969 [details]
Bug 1306276 - Deprecate History RemovePage and RemovePages.
https://reviewboard.mozilla.org/r/122738/#review125416
Nice!
Attachment #8849969 -
Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/c370886b741c
Deprecate History RemovePage and RemovePages. r=standard8
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•8 years ago
|
status-firefox52:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•