Blocking bug for loading the inspector in a content tab (Bug 1291049). computed/computed.js relies on Iterator, which is a Firefox-only API that is made accessible to computed.js via the _Iterator global. _Iterator is not available in content. We should either rely on Iterator directly or use a cross browser shim (better).

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cb7409c821e14716727b4c85574a648f6e9746c

Comment on attachment 8801698 [details] Bug 1310211 - remove usage of deprecated Iterator in computed.js; https://reviewboard.mozilla.org/r/86378/#review85150 Thanks for doing this. I think this is reasonable. Looking at the code, I think it would be way simpler using Task.async; but this approach is clearly fine.

Try looks green. Had my doubts about dt4 on linux32 debug, but it doesn't seem worst than usual. Plus the failing test will get a longer timeout as of Bug 1309212. (auto) landing

(In reply to Tom Tromey :tromey from comment #4) > Comment on attachment 8801698 [details] > Bug 1310211 - remove usage of deprecated Iterator in computed.js; > > https://reviewboard.mozilla.org/r/86378/#review85150 > > Thanks for doing this. > > I think this is reasonable. Looking at the code, I think it would be way > simpler using Task.async; but this approach is clearly fine. Thanks for the review! I agree about Task.async, here I wanted to stay as close as possible to the existing implementation to avoid unrelated issues.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4379d8d91f2 remove usage of deprecated Iterator in computed.js;r=tromey