Closed
Bug 1311848
Opened 8 years ago
Closed 8 years ago
[EME] MOZ_ASSERT(mPendingSessions.Contains(token)) fail in drm-mp4-syntax-mediakeysession.html
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
I hit an assert when I run web platform test drm-mp4-syntax-mediakeysession.html:
xul.dll!mozilla::dom::MediaKeys::RejectPromise(unsigned int aId, nsresult aExceptionCode, const nsCString & aReason) Line 239 C++
xul.dll!mozilla::GMPCDMProxy::RejectPromise(unsigned int aId, nsresult aCode, const nsCString & aReason) Line 502 C++
xul.dll!mozilla::GMPCDMProxy::OnRejectPromise(unsigned int aPromiseId, nsresult aDOMException, const nsCString & aMsg) Line 658 C++
xul.dll!mozilla::RejectPromiseTask::Run() Line 116 C++
The problem is that we're calling MediaKeys::ConnectPendingPromiseIdWithToken() on the MediaKeySession::Load() path, but we actually don't need to; inside Load() we already know the session Id, and we've already removed the session from the list of pending sessions in Load(), so the assertion fails.
We should not be calling MediaKeys::ConnectPendingPromiseIdWithToken() inside MediaKeySession::Load().
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8803139 [details]
Bug 1311848 - Don't call ConnectPendingPromiseIdWithToken in MediaKeySession::Load.
https://reviewboard.mozilla.org/r/87364/#review86462
Attachment #8803139 -
Flags: review?(kikuo) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/255e360cf9be
Don't call ConnectPendingPromiseIdWithToken in MediaKeySession::Load. r=kikuo
Comment 4•8 years ago
|
||
Landed 22 hours ago https://hg.mozilla.org/mozilla-central/rev/255e360cf9be
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•