[Affected versions]: - Firefox 52.0a2 (2016-12-22), Firefox 53.0a1 (2016-12-22) [Affected platforms]: - Ubuntu 16.04x64, Windows 8.1x86, Mac 10.12.1 [Steps to reproduce]: Prerequisites: Make sure that devtools.responsive.html.enabled pref is set to true. 1. Launch Firefox. 2. Enable RDM. 3. Open the list of devices and click on the 'Edit list...' button in order to open the modal. 4. Click on the check boxes using the right click. [Expected result]: - The context menu is displayed. [Actual result]: - The context menu is displayed and the checkbox is checked/unchecked. [Regression range]: - This is not a regression. Here is the pushlog in order to see when the modal was implemented: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=c1a9497a212d54fda334e9174aac33926196df8e&tochange=be1fd1c7e43f3969243b8c768d5dbe6de17f4f7c .

Thanks for filing! I can reproduce this. It seems like a low priority issue. I think this could be fixed by editing onDeviceCheckboxClick in devtools/client/responsive.html/components/device-modal.js to filter out other mouse buttons. Check out https://wiki.mozilla.org/DevTools/Hacking to get started with the code base.

At [0], you'll need to add access to event.button like this: `onDeviceCheckboxClick({ button, target }) {` then you'll need to add a check on whether event.button isn't 0 (left click), if not, then return early: ` if (button !== 0) { return; } ` [0]: https://dxr.mozilla.org/mozilla-central/source/devtools/client/responsive.html/components/device-modal.js#52

Will submit a patch soon, assigning myself.

Thanks Tim for the solution. Hope this helps, jryans Happy new year to all ;)

Comment on attachment 8822912 [details] [diff] [review] leftclickcheck.patch Review of attachment 8822912 [details] [diff] [review]: ----------------------------------------------------------------- Great, that appears to fix the issue. Thanks for working on it!

Thanks for the review :jryans Adding checkin-needed

Here's a try run, just in case... I expect it will be fine. https://treeherder.mozilla.org/#/jobs?repo=try&revision=41d226c8de5b4f514db05d2031f15154cf7653cd

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/423594fd6c7e The checkboxes from modal can now be checked/unchecked using the left click only; r=jryans

sorry had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=66086948&repo=mozilla-inbound

Backout by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0496c868606e Backed out changeset 423594fd6c7e for eslint failure

Hi Tomcat, I really won't be able to understand most of the treeherder reports. But if this is about the eslint errors in the whole file, I can look into it. But won't it be on another bug to fix the eslint errors ?

hi towkir, the things is that the changes here in this patch caused the error and so we had to back this out to prevent this test failure. Before we can land this change again we need to fix this error. Not sure how to fix this error maybe Ryan knows

Hmm, I think this happens to me every time I think something's ready without a try run... :) Two issues it seems: * ESLint error in the new code (missing a space) * We actually needed to pull the button from the `nativeEvent` that React is wrapping (didn't realize this is actually a "change" event handler, which React does some special processing on) Here's a hopefully fixed run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fed495f4aae3b6863c5139d6d7fd235cd084eb38 Definitely going to wait this time... :) I have to re-learn this lesson every few months...

Comment on attachment 8823754 [details] Bug 1325570 - The checkboxes from modal can now be checked/unchecked using the left click only; https://reviewboard.mozilla.org/r/102258/#review102604

Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/fb2bfbb47491 The checkboxes from modal can now be checked/unchecked using the left click only; r=jryans

Ryan, do you think it is something we should uplift to 52? Thanks

(In reply to Sylvestre Ledru [:sylvestre] from comment #18) > Ryan, do you think it is something we should uplift to 52? Thanks I think we can leave it out of 52.

I have reproduced this bug with Nightly 53.0a1 (2016-12-23) (64-bit) on Windows 7 , 64 Bit! This bug's fix is verified with latest Developer Edition (Aurora)! Build ID : 20170215004022 User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 [bugday-20170215]

Thanks Maruf Rahman for helping. I've also verified this issue on Firefox 53.0b1, Firefox 54.0a2 (2017-03-07), Firefox 55.0a1 (2017-03-07), under Mac OS X 10.12.1 and under Ubuntu 16.04x64.