Closed Bug 1331510 Opened 8 years ago Closed 8 years ago

Inspector loads non-existing CSS file resource://devtools/client/shared/widgets/widgets.css

Categories

(DevTools :: Inspector, defect, P2)

51 Branch
defect

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: Gijs, Assigned: jdescottes)

References

Details

(Keywords: regression)

Attachments

(1 file)

As of bug 1309733, we load resource://devtools/client/shared/widgets/widgets.css which doesn't exist. Julian, can you clarify why you changed this from the existing chrome:// URL and check if anything is going to break if we unbreak the URL?
Flags: needinfo?(jdescottes)
Sorry I missed that! I don't there is any good reason. I probably wanted to migrate the css to be loaded as a resource file, but it didn't make it in the final patch. The only rules impacting the inspector contained in this css are: > .breadcrumbs-widget-item { > direction: ltr; > } > > .breadcrumbs-widget-item { > -moz-user-focus: normal; > } The first rule will actually break the RTL display of the breadcrumbs in the inspector so I'd like to avoid it. I think we should just stop loading this stylesheet completely.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Flags: needinfo?(jdescottes)
Priority: -- → P2
Comment on attachment 8827302 [details] Bug 1331510 - remove unused shared/widgets.css stylesheet from inspector.xhtml; https://reviewboard.mozilla.org/r/105014/#review105910
Attachment #8827302 - Flags: review?(pbrosset) → review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a55df40a9a8 remove unused shared/widgets.css stylesheet from inspector.xhtml;r=pbro
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Please request Aurora approval on this when you get a chance.
Flags: needinfo?(jdescottes)
Comment on attachment 8827302 [details] Bug 1331510 - remove unused shared/widgets.css stylesheet from inspector.xhtml; Approval Request Comment [Feature/Bug causing the regression]:1309733 [User impact if declined]: no direct user impact, but a devtools panel attempts to load a non-existing css which logs confusing errors for developers (cf Bug 1330123) [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: we just removed the link tag pointing to the non-existing css. This can't have any impact. [String changes made/needed]: none
Flags: needinfo?(jdescottes)
Attachment #8827302 - Flags: approval-mozilla-aurora?
Comment on attachment 8827302 [details] Bug 1331510 - remove unused shared/widgets.css stylesheet from inspector.xhtml; devtools inspector fix, aurora52+
Attachment #8827302 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: